TPT-4490: Support for firewall rules with numeric and ALL protocols

[lgarber-akamai]

📝 Description

This pull request adds support for managing firewall rules with numeric and ALL protocols.

✔️ How to Test

NOTE: This feature is not yet generally available. See TPT-4469 for required test environment information.

Unit Testing

make test-unit

Integration Testing

make fixtures TEST_ARGS="-run TestFirewallRules_ExtendedProtocols"

[Copilot]

Pull request overview

Adds client/test support for Cloud Firewall rules using extended protocol values: the ALL protocol and numeric IP protocol numbers, ensuring these values serialize and round-trip correctly through create/get flows.

Changes:

• Introduces ProtocolALL as a NetworkProtocol constant and updates NetworkProtocol documentation.
• Adds a unit test covering JSON marshaling for ALL and numeric protocol values (with/without ports).
• Adds an integration test + VCR fixture validating firewall creation and retrieval with extended protocols.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
firewall_rules.go	Documents extended protocol usage and adds a protocol constant for ALL.
test/unit/firewall_rules_test.go	Adds unit coverage for marshaling rules with ALL and numeric protocols.
test/integration/firewall_rules_test.go	Adds an integration test exercising create/get behavior with extended protocols.
test/integration/fixtures/TestFirewall_CreateWithExtendedProtocols.yaml	Records API interactions for the new integration test scenario.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[lgarber-akamai]

I ended up settling on linodego.AllNetworkProtocols instead of the more generic linodego.ALL or ambiguous linodego.ProtocolAll. Let me know if you have any thoughts or ideas!

[ezilber-akamai]

Tests passed locally!