TPT-4622: Re-enable cheap golangci-lint checks - #1031
Open
zliang-akamai wants to merge 3 commits into
Open
Conversation
Enable errorlint, godox, inamedparam, and nolintlint, and fix the small findings those checks report.
zliang-akamai
added
the
repo-ci-improvement
zliang-akamai
requested review from
mawilk90 and
yec-akamai
and removed request for
a team
August 24, 2026 17:21
Contributor
There was a problem hiding this comment.
Pull request overview
Re-enables selected cheap golangci-lint checks and updates affected Go code.
Changes:
- Re-enables
errorlint,godox,inamedparam, andnolintlint. - Updates error wrapping,
//nolintdirectives, and interface parameter names.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Summary |
|---|---|
waitfor.go |
Updates error wrapping and lint directives. |
request_helpers.go |
Normalizes the funlen directive. |
pagination.go |
Names interface parameters and normalizes directives. |
client.go |
Updates error wrapping and lint directives. |
.golangci.yml |
Re-enables four linters; existing @TODO comments will cause godox failures and require removal or suppression. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Bare //nolint is rewritten by gofumpt to // nolint, which then fails nolintlint. Name the suppressed linters so CI format and lint agree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Re-enable
errorlint,godox,inamedparam, andnolintlintso these cheap checks run in CI. Existing//nolintcomments are normalized, wrappingfmt.Errorfcalls use%w, andPagedResponseinterface methods have named parameters.✔️ How to Test