TPT-4456: Enable integration test for RDMA Linode interface - #1032
Open
yec-akamai wants to merge 6 commits into
Open
TPT-4456: Enable integration test for RDMA Linode interface#1032yec-akamai wants to merge 6 commits into
yec-akamai wants to merge 6 commits into
Conversation
yec-akamai
requested review from
lgarber-akamai and
psnoch-akamai
and removed request for
a team
August 27, 2026 19:42
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the previously skipped RDMA VPC Linode interface integration test by updating the test setup (firewall handling, fixed region/plan selection) and refreshing the go-vcr cassette to match the new recorded interactions.
Changes:
- Stop skipping
TestInstance_CreateWithRDMAVPCInterfacesand update the instance creation options used by the test (region/plan, firewall opt-out behavior). - Ensure
FirewallIDis explicitly set to-1on interfaces when Cloud Firewall is disabled (to avoid implicit/default firewall behavior). - Update the recorded integration fixture
TestInstance_CreateWithRDMAVPCInterfaces.yamlto align with the new request/response sequence and IDs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/integration/instance_interfaces_test.go | Enables the RDMA interface integration test and adjusts instance/interface creation defaults (firewall opt-out, region/plan selection). |
| test/integration/fixtures/TestInstance_CreateWithRDMAVPCInterfaces.yaml | Updates the VCR fixture to reflect the new recorded API interactions for the RDMA interface test. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Remove skipping the test and allow to run the case.
✔️ How to Test