doc: add error-log command description for fields and ordering#3344
Conversation
As all fields including the ordering described in the spec. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
ikegami-t
force-pushed
the
doc-error-log
branch
4 times, most recently
from
8e22fed to
7033544
Compare
|
Currently added 9 commits for the error-log command changes then if needed will do combine the commits or separate the PR so please let me know. |
| const char *trtype = "output specified TRTYPE entry only"; | ||
| const char *opcode = "output specified OPC entry only"; | ||
| const char *sqid = "output specified SQID entry only"; | ||
| const char *valid_entry = "output valid entry only"; |
There was a problem hiding this comment.
as far I can tell, valid_entry is not used anymore. Maybe you could merge this patches together so it's only one patch? I mean the patches which introduce this filter logic.
There was a problem hiding this comment.
No still the valid-entry option is used so needed to remain. Okay I will do merge the patches to introduce the filter logic.
| obj_add_str(error, "no error", "all entries filtered"); | ||
| array_add_obj(errors, error); | ||
| } | ||
|
|
There was a problem hiding this comment.
Not sure if we should add this at all. The users asked for filtering and if there are no entries, we just return an empty array, no?
There was a problem hiding this comment.
Just followed as same with the stdout output but yes will do delete the object for the json output.
|
Looks good, I would just merge the filter logic patches into one. Could also update the documentation and the shell completion? But this can go also afterwards. Thanks! |
Add valid-entry option argument to filter invalid entries. Also add status, LBA and nsid etc,. fields option arguments to filter. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Since incorrectly some fields are printed as little endian. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
This is to align the function coding style. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Since previously only added the fields for the print-stdout. Fixes: 90d9c1a ("print: print csi and opcode in error log (TP4113)") Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Fix the maximum line length 80 warnings. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Use it to get the phase tag and status fields values. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
|
Just fixed the patches as metioned. Sorry let me update the documentation and the shell completion separately. I will do that later by additional a patch or PR. Thank you. |
|
Thanks! |
2 participants
As all fields including the ordering described in the spec.