libnvme: drop the static stat buffer in nvme_verify_chr() - #3917
Merged
Conversation
The fstat() target is a static struct stat shared across all threads, so concurrent reset/ns-rescan calls on different handles race writing into it and can observe a torn st_mode. There is no shared state worth keeping. Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
Collaborator
|
dropped the libnvme 1 reference. |
igaw
force-pushed
the
fix-verify-chr-static
branch
from
August 26, 2026 14:06
c0ef703 to
5699b68
Compare
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
nvme_verify_chr()uses astatic struct statas the fstat() target, shared across all threads — concurrent resets / rescans on different transport handles race writing into it and can observe a tornst_mode. (The companion 1.x issue of returning a positive errno, linux-nvme/libnvme#1130, is already correct in this tree — it returns-errno.)Fix
Make the buffer automatic; nothing in the function is meant to be shared or retained.
Testing