libnvme: examples: free the context in display-columnar - #3920
Merged
igaw merged 1 commit intoAug 27, 2026
Conversation
The example builds the scanned topology into the global context but exits without releasing it; every other scanning example calls libnvme_free_global_ctx(). The process exits right after, so impact is nil at runtime, but the example models incomplete teardown for anyone copying it. Signed-off-by: Prabhakar Pujeri <prabhakar.pujeri@dell.com>
igaw
force-pushed
the
fix-display-columnar-free
branch
from
August 27, 2026 09:31
be1f4c0 to
06ccbd7
Compare
Collaborator
|
removed the libnvme 1 reference. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Port of linux-nvme/libnvme#1141.
display-columnarbuilds the topology into the global context but never releases it on exit (every other scanning example callslibnvme_free_global_ctx()). Runtime impact nil, but the example is regularly copied as a starting template and should model complete teardown.Fix
Call
libnvme_free_global_ctx(ctx)before returning frommain().Testing