Closed
build: update packaging files to use PEP 517/518 tooling after setup.py removal#17
Conversation
Update debian/rules, rpm/nvmetcli.spec.tmpl, README, and bump-ver.sh to use python3 -m build / pip3 install instead of setup.py, since setup.py has been replaced by pyproject.toml. Co-authored-by: igaw <1050803+igaw@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code based on review comment 3804462438
build: update packaging files to use PEP 517/518 tooling after setup.py removal
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
debian/rules,rpm/nvmetcli.spec.tmpl,README, andbump-ver.shall referencedsetup.pywhich was replaced bypyproject.toml, breaking distro builds and the version-bump workflow.Changes
debian/rules— replacepython setup.py build/installwithpython3 -m build/pip3 install; switch--with python2→--with python3rpm/nvmetcli.spec.tmpl— updateBuildRequirestopython3-devel/pip/build; replace%{__python} setup.pyinvocations with%{__python3} -m buildandpip3 installbump-ver.sh— retarget versionsedtopyproject.toml(version = "...") and updategit addREADME— update install instruction fromsetup.pytopip install .