Skip to content

sync: from linuxdeepin/dde-session-shell - #528

Merged
BLumia merged 1 commit into
masterfrom
sync-pr-79-nosync
Aug 27, 2026
Merged

sync: from linuxdeepin/dde-session-shell#528
BLumia merged 1 commit into
masterfrom
sync-pr-79-nosync

Conversation

@deepin-ci-robot

@deepin-ci-robot deepin-ci-robot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#79

Summary by Sourcery

Complete missing localization strings in the Arabic and Portuguese translation catalogs.

Enhancements:

  • Complete Arabic translations for authentication, session, account, update, and power-management user interface messages.
  • Add Portuguese translations for multifactor authentication login prompts.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @deepin-ci-robot, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@sourcery-ai

sourcery-ai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR syncs a portion of the Portuguese translation file with the upstream linuxdeepin/dde-session-shell project by replacing unfinished entries with complete translations for MFA login-related messages.

File-Level Changes

Change Details Files
Complete previously unfinished Portuguese translations for MFA login widget messages related to SMS verification.
  • Replace unfinished translation for '发送验证码' with a Portuguese translation meaning 'Send verification code'.
  • Replace unfinished translation for '请输入手机号' with a Portuguese translation prompting the user to enter their phone number.
  • Replace unfinished translation for '请输入验证码' with a Portuguese translation prompting the user to enter the verification code.
  • Replace unfinished translation for '获取验证码' with a Portuguese translation meaning 'Get verification code'.
translations/dde-session-shell_pt.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Synchronize source files from linuxdeepin/dde-session-shell.

Source-pull-request: linuxdeepin/dde-session-shell#79
@deepin-ci-robot

Copy link
Copy Markdown
Contributor Author

deepin pr auto review

🤖 AI 代码审查报告

总体评分: 97 分 (通过阈值: 70分)

Pass


📊 总体评价

项目 结果
审查结论 代码审查通过
评分详情 总体评分 97 分,大于 70 分通过阈值,代码质量符合要求。本次提交为翻译文件同步更新,补全阿拉伯语和葡萄牙语本地化字符串,未发现安全漏洞,存在1处翻译准确性问题需改进。

🔍 详细分析

1. 语法逻辑 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: XML结构正确,所有translation标签格式完整,numerus复数条目包含正确的6个numerusform子元素(阿拉伯语复数规则)。%n占位符在所有翻译中正确保留。


2. 代码质量 ✅

评价: 良好 ✅ 通过

潜在问题:

  1. translations/dde-session-shell_ar.ts:14 - 阿拉伯语双数形式(n=2)错误:所有numerus条目的第3个numerusform使用了单数形式而非双数形式,影响多个认证组件的复数翻译

建议: 修正所有阿拉伯语numerus条目的第3个numerusform(index 2,n=2的双数形式)。涉及4个源字符串共8处以上的翻译条目:1."Verification failed, %n chances left" - 第3形式改为"فشل التحقق، %n فرصتان متبقيتان";2."Please try again %n minutes later" - 第3形式改为"يرجى المحاولة مرة أخرى بعد %n دقيقتان";3."Please try again %n minute(s) later" - 第3形式改为"يرجى المحاولة مرة أخرى بعد %n دقيقتان";4."Your password will expire in %n days" - 第3形式改为"ستنتهي صلاحية كلمة المرور الخاصة بك خلال %n يومان، يرجى تغييرها في الوقت المناسب"。


3. 代码性能 ✅

评价: 优秀 ✅ 通过

潜在问题:
✅ 未发现明显问题

建议: 翻译文件为静态XML数据文件,在构建时编译,无运行时性能影响。无性能优化空间。


4. 代码安全 🔒

评价: 优秀 ✅ 通过

🔐 发现 0 个安全漏洞

安全漏洞详情:
✅ 未发现安全漏洞

建议: 翻译文件仅包含UI显示文本,无用户输入处理、无代码执行、无注入风险。未发现任何安全漏洞。建议保持翻译内容的审查流程,确保不引入敏感信息。


💡 改进建议代码示例

<!-- 修正前(错误:第3形式使用单数) -->
<translation>
  <numerusform>فشل التحقق، %n فرصة متبقية</numerusform>
  <numerusform>فشل التحقق، %n فرصة متبقية</numerusform>
  <numerusform>فشل التحقق، %n فرصة متبقية</numerusform> <!-- 错误:n=2应使用双数 -->
  <numerusform>فشل التحقق، %n فرص متبقية</numerusform>
  <numerusform>فشل التحقق، %n فرصة متبقية</numerusform>
  <numerusform>فشل التحقق، %n فرصة متبقية</numerusform>
</translation>

<!-- 修正后(正确:第3形式使用双数) -->
<translation>
  <numerusform>فشل التحقق، %n فرصة متبقية</numerusform>
  <numerusform>فشل التحقق، %n فرصة متبقية</numerusform>
  <numerusform>فشل التحقق، %n فرصتان متبقيتان</numerusform> <!-- 正确:n=2使用双数 -->
  <numerusform>فشل التحقق، %n فرص متبقية</numerusform>
  <numerusform>فشل التحقق، %n فرصة متبقية</numerusform>
  <numerusform>فشل التحقق، %n فرصة متبقية</numerusform>
</translation>

本报告由 AI 代码审查工具自动生成

@deepin-ci-robot

Copy link
Copy Markdown
Contributor Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, deepin-ci-robot

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BLumia
BLumia merged commit 44975e1 into master Aug 27, 2026
25 of 27 checks passed
@BLumia
BLumia deleted the sync-pr-79-nosync branch August 27, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants