fix(a11y): add AT-SPI accessible names/roles for dde-shell panels - #1712
Draft
MyLeeJiEun wants to merge 1 commit into
Draft
fix(a11y): add AT-SPI accessible names/roles for dde-shell panels#1712MyLeeJiEun wants to merge 1 commit into
MyLeeJiEun wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MyLeeJiEun The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @MyLeeJiEun. Thanks for your PR. I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reviewer's GuideAdds AT-SPI accessible names and roles throughout dde-shell’s native task-manager widgets and QML panel surfaces, while introducing a 183-entry YAML baseline to detect future accessibility coverage regressions; behavior and layout are otherwise unchanged. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
MyLeeJiEun
force-pushed
the
fix/at-spi-completion-20260826
branch
from
August 26, 2026 06:05
c352bc0 to
93f095d
Compare
Add setObjectName()/setAccessibleName() to C++ widgets and Accessible.name/Accessible.role to QML elements across dock, notification, tray, frame, shell and example panels. Also add the expected_names.yaml regression baseline under tests/at/spi/. Log: 补全 dde-shell 各面板 AT-SPI 无障碍名称与角色 Influence: 提升无障碍工具与自动化测试对 Dock/通知中心控件的识别率
MyLeeJiEun
force-pushed
the
fix/at-spi-completion-20260826
branch
from
August 26, 2026 06:19
93f095d to
aaa98c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AT-SPI Accessibility Completion for dde-shell
Summary
Completes AT-SPI accessible name/role coverage across dde-shell panels. Adds
setObjectName()/setAccessibleName()to C++ widgets andAccessible.name/Accessible.roleto QML elements, plus anexpected_names.yamlregression baseline.Related issue: DDE-160 (为 dde-shell 补全 AT-SPI 支持)
Coverage Results
The remaining 8 QML gaps are non-visual types (SortFilterModel, DelegateChooser, SequentialAnimation subclasses) where the
Accessibleattached property is not applicable — correctly skipped.Changes
C++ (1 file, 2 gaps fixed):
panels/dock/taskmanager/x11preview.cpp— addedsetObjectName()+setAccessibleName()form_closeAllButtonandm_listViewQML (57 files, 173 gaps fixed):
Accessible.nameonly (role auto-inferred by Qt C++ backend)Accessible.name(viaqsTr()) andAccessible.role(mapped per component type)Accessibleattached property not applicableRegression baseline:
tests/at/spi/expected_names.yaml— 2 C++ widgets + 181 QML elements, for future quality-gate regression checksNotes
setObjectName()/setAccessibleName()calls onQListView*andDIconButton*(both QWidget subclasses).Draft PR — please review.
Summary by Sourcery
Complete AT-SPI accessibility metadata across dde-shell panels without changing their behavior or layout.
Bug Fixes:
Enhancements:
Tests:
Chores: