Skip to content

fix(dde-apps): return empty list when firstNItems count <= 0 #1715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MyLeeJiEun wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −2
Draft

fix(dde-apps): return empty list when firstNItems count <= 0 #1715

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a19565b
fix(dde-apps): return empty list when firstNItems count <= 0
MyLeeJiEun Aug 26, 2026
4c2ed2a
chore(dde-apps): update SPDX copyright year to 2023-2026
MyLeeJiEun Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion applets/dde-apps/itemspage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// SPDX-FileCopyrightText: 2023 UnionTech Software Technology Co., Ltd.
// SPDX-FileCopyrightText: 2023-2026 UnionTech Software Technology Co., Ltd.
//
// SPDX-License-Identifier: GPL-3.0-or-later

Expand Down Expand Up @@ -52,9 +52,11 @@
return m_pages.at(page);
}

QStringList ItemsPage::firstNItems(int count)

Check warning on line 55 in applets/dde-apps/itemspage.cpp

View workflow job for this annotation

GitHub Actions / cppcheck 

The function 'firstNItems' is never used.
{
QStringList result;
if (count <= 0)
return result;

for (const QStringList & pageItems : std::as_const(m_pages)) {
for (const QString & item : pageItems) {
Expand Down
2 changes: 1 addition & 1 deletion applets/dde-apps/itemspage.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// SPDX-FileCopyrightText: 2023 UnionTech Software Technology Co., Ltd.
// SPDX-FileCopyrightText: 2023-2026 UnionTech Software Technology Co., Ltd.
//
// SPDX-License-Identifier: GPL-3.0-or-later

Expand Down
Loading