Skip to content

feat: migrate showdesktop and multitaskview to treeland-compositor-action-unstable-v1 protocol - #1757

Closed
deepin-wm wants to merge 1 commit into
linuxdeepin:masterfrom
deepin-wm:agent/developer/562990c5db44
Closed

deepin-wm wants to merge 1 commit into
linuxdeepin:masterfrom
deepin-wm:agent/developer/562990c5db44

Conversation

@deepin-wm

@deepin-wm deepin-wm commented Oct 12, 2026 •

Copy link
Copy Markdown

Summary

Migrate dde-shell's showdesktop and multitaskview panels from treeland-show-desktop-unstable-v1 / treeland-dde-shell-v1 protocols to the unified treeland-compositor-action-unstable-v1 protocol.

  • Replace old stateful wrappers with a single TreelandCompositorAction wrapper class per panel
  • showdesktop: trigger(action_show_desktop) replaces the old set_show_desktop_state + state tracking
  • multitaskview: trigger(action_toggle_multitask_view) replaces the old two-step manager → worker → toggle pattern
  • treeland-protocols build dependency upgraded to 0.7.0
  • debian/control build dependency updated accordingly

Changes (11 files, net -39 lines)

  • panels/dock/showdesktop/: treelandshowdesktop.h/cpp → treelandcompositoraction.h/cpp, wrapper rewrite, state tracking removed, CMakeLists.txt updated
  • panels/dock/multitaskview/: treelandmultitaskview.h/cpp → treelandcompositoraction.h/cpp, two-step worker removed, CMakeLists.txt updated
  • debian/control: treeland-protocols (>> 0.5.9) → treeland-protocols (>> 0.7.0)

Related

Summary by Sourcery

Adopt the unified Treeland compositor action protocol for desktop, multitask, and shutdown controls.

New Features:

  • Migrate show desktop, multitask view, and lock-screen actions to the unified Treeland compositor action protocol.

Enhancements:

  • Remove legacy stateful and multi-step DDE shell protocol wrappers in favor of direct compositor action triggers.
  • Remove the dock's obsolete DDE shell manager integration.

Build:

  • Require TreelandProtocols 0.7.0 and generate clients from the compositor action protocol.

@deepin-ci-robot

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sourcery-ai

sourcery-ai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Reviewer's Guide

Migrates show-desktop, multitask-view, and shutdown actions from legacy Treeland protocol wrappers to direct treeland-compositor-action-unstable-v1 triggers, removes obsolete DDE shell integration, and raises the protocol build dependency to 0.7.0.

Sequence diagram for unified compositor action triggers

sequenceDiagram
    participant ShowDesktop
    participant MultiTaskView
    participant Shutdown
    participant CompositorAction as TreelandCompositorAction
    participant Compositor as TreelandCompositor

    ShowDesktop->>CompositorAction: desktopToggle()
    CompositorAction->>Compositor: trigger(action_show_desktop)

    MultiTaskView->>CompositorAction: toggle()
    CompositorAction->>Compositor: trigger(action_toggle_multitask_view)

    Shutdown->>CompositorAction: lock()
    CompositorAction->>Compositor: trigger(action_lockscreen)
    Shutdown->>CompositorAction: shutdown()
    CompositorAction->>Compositor: trigger(action_shutdown_menu)
    Shutdown->>CompositorAction: switchUser()
    CompositorAction->>Compositor: trigger(action_show_user_switch)
Loading

File-Level Changes

Change Details Files
Replace legacy Treeland protocol clients with direct compositor-action clients for dock actions.
  • Generate clients from treeland-compositor-action-unstable-v1 and require TreelandProtocols 0.7.0.
  • Trigger show-desktop and multitask-view actions directly when the protocol is active.
  • Remove legacy state tracking and the multitask manager/worker handshake.
panels/dock/showdesktop/CMakeLists.txt
panels/dock/showdesktop/showdesktop.cpp
panels/dock/showdesktop/showdesktop.h
panels/dock/showdesktop/treelandcompositoraction.cpp
panels/dock/showdesktop/treelandcompositoraction.h
panels/dock/showdesktop/treelandshowdesktop.cpp
panels/dock/showdesktop/treelandshowdesktop.h
panels/dock/multitaskview/CMakeLists.txt
panels/dock/multitaskview/multitaskview.cpp
panels/dock/multitaskview/multitaskview.h
panels/dock/multitaskview/treelandcompositoraction.cpp
panels/dock/multitaskview/treelandcompositoraction.h
panels/dock/multitaskview/treelandmultitaskview.cpp
panels/dock/multitaskview/treelandmultitaskview.h
Migrate shutdown controls to compositor actions and remove the legacy DDE shell lockscreen worker.
  • Generate the compositor-action client and require TreelandProtocols 0.7.0.
  • Map lock, shutdown menu, and user-switch operations to the corresponding compositor action IDs.
  • Destroy the client extension explicitly and eliminate the old manager/worker protocol objects.
applets/dde-shutdown/CMakeLists.txt
applets/dde-shutdown/treelandlockscreen.cpp
applets/dde-shutdown/treelandlockscreen.h
Remove unused dock-wide DDE shell protocol integration.
  • Stop generating and including the legacy DDE shell protocol.
  • Remove the unused manager member and initialization from the dock Wayland helper.
panels/dock/CMakeLists.txt
panels/dock/waylanddockhelper.cpp
panels/dock/waylanddockhelper.h
Raise the Debian build requirement for the new protocol definitions.
  • Require treeland-protocols newer than 0.7.0 at package build time.
debian/control

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@deepin-wm
deepin-wm force-pushed the agent/developer/562990c5db44 branch from 47d310b to f7f31b9 Compare October 12, 2026 10:25
@deepin-bot

deepin-bot Bot commented Oct 12, 2026

Copy link
Copy Markdown

TAG Bot

New tag: 2.0.57
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1758

@deepin-wm
deepin-wm force-pushed the agent/developer/562990c5db44 branch 6 times, most recently from 2216384 to 6a1f92b Compare October 13, 2026 02:38
…ocol

1. Rewrite showdesktop wrapper to use treeland-compositor-action-unstable-v1
2. Rewrite multitaskview wrapper to use treeland-compositor-action-unstable-v1
3. Remove old state tracking logic from showdesktop wrapper
4. Remove two-step worker pattern from multitaskview wrapper
5. Update CMakeLists.txt to use new protocol XML and treeland-protocols 0.7.0
6. Update debian/control build dependency to treeland-protocols (>= 0.7.0)

Log: Migrated show desktop and multitask view to compositor action protocol

Influence:
1. Test show desktop toggle on Wayland session
2. Test multitask view toggle on Wayland session
3. Verify X11 fallback paths remain unchanged
4. Verify build with treeland-protocols 0.7.0 installed

feat: 迁移显示桌面和多任务视图至 compositor-action 协议

1. 重写 showdesktop 包装类,使用 treeland-compositor-action-unstable-v1 协议
2. 重写 multitaskview 包装类,使用 treeland-compositor-action-unstable-v1 协议
3. 移除 showdesktop 包装类中旧的状态跟踪逻辑
4. 移除 multitaskview 包装类中的两步式 worker 模式
5. 更新 CMakeLists.txt 使用新协议 XML 和 treeland-protocols 0.7.0
6. 更新 debian/control 构建依赖至 treeland-protocols (>= 0.7.0)

Log: 迁移显示桌面和多任务视图功能至 compositor action 协议

Influence:
1. 在 Wayland 会话下测试显示桌面切换功能
2. 在 Wayland 会话下测试多任务视图切换功能
3. 验证 X11 回退路径保持不变
4. 验证安装 treeland-protocols 0.7.0 后可正常编译
@deepin-wm
deepin-wm force-pushed the agent/developer/562990c5db44 branch from 6a1f92b to 8b128b4 Compare October 13, 2026 02:53
@wineee
wineee marked this pull request as ready for review October 13, 2026 03:21

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, deepin-wm

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot

Copy link
Copy Markdown

@deepin-wm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
github-trigger-obs-ci 8b128b4 link true /test github-trigger-obs-ci

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wineee

wineee commented Oct 13, 2026

Copy link
Copy Markdown
Member

#1760

@wineee wineee closed this Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants