fix(markdown): unify table border color and fix rounded corner gaps - #545
Conversation
Use a dedicated --table-border (10% overlay) for the table frame and cell grid, and hide the table's outer left/right/bottom borders so the rounded block border closes cleanly without clipped-line gaps. 表格边框改用专用 --table-border(10% 半透明叠加),外框与单元格网格线 同色;隐藏表格左/右/底外边框,由外层圆角边框封闭,消除转角缺口。 Log: 修复Markdown表格边框颜色不一致及圆角转角缺口 Influence: Markdown预览区表格边框颜色统一、转角渲染完整,深浅色主题均适配。
Reviewer's GuideUnifies Markdown table frame and cell-grid colors through a light/dark theme-aware --table-border token, and hides conflicting collapsed-table outer edges so the surrounding rounded border renders complete corners without gaps. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 优秀 ✅ 通过 潜在问题: 建议: CSS 语法正确,变量定义与级联覆盖逻辑清晰,border-collapse 下 hidden 优先级规则运用准确 2. 代码质量 ✅评价: 优秀 ✅ 通过 潜在问题:
建议: 建议将 build/style.css 纳入构建流程自动生成,避免源文件与编译产物不同步;当前两处文件内容一致,暂无实际问题 3. 代码性能 ✅评价: 优秀 ✅ 通过 潜在问题: 建议: CSS 变量复用有利于浏览器缓存和主题切换性能,无不必要的重绘或回流 4. 代码安全 🔒评价: 优秀 ✅ 通过
漏洞对比统计:
安全漏洞详情: 建议: 纯 CSS 样式变更,无安全风险 💡 改进建议代码示例/* 建议在构建脚本中添加自动拷贝/编译步骤,避免手动同步两份文件 */
/* 例如在 package.json 或 Makefile 中: */
/* cp src/editor/markdown/web/theme.css src/editor/markdown/web/build/style.css */
/* 或者在 .gitignore 中忽略 build/ 目录,仅保留源文件 */
/* echo 'src/editor/markdown/web/build/' >> .gitignore */本报告由 AI 代码审查工具自动生成 |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lzwind, pengfeixx The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/merge |
Use a dedicated --table-border (10% overlay) for the table frame and cell grid, and hide the table's outer left/right/bottom borders so the rounded block border closes cleanly without clipped-line gaps.
表格边框改用专用 --table-border(10% 半透明叠加),外框与单元格网格线
同色;隐藏表格左/右/底外边框,由外层圆角边框封闭,消除转角缺口。
Log: 修复Markdown表格边框颜色不一致及圆角转角缺口
Influence: Markdown预览区表格边框颜色统一、转角渲染完整,深浅色主题均适配。
Summary by Sourcery
Unify Markdown table borders and close rounded corners cleanly across themes.
Bug Fixes:
Enhancements: