Skip to content

feat: 补全 AT-SPI 无障碍名称 - #546

Draft
re2zero wants to merge 1 commit into
linuxdeepin:masterfrom
re2zero:fix/at-spi-completion-20260826
Draft

feat: 补全 AT-SPI 无障碍名称#546
re2zero wants to merge 1 commit into
linuxdeepin:masterfrom
re2zero:fix/at-spi-completion-20260826

Conversation

@re2zero

@re2zero re2zero commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

概述

为缺失无障碍名称的交互控件添加 setObjectName/setAccessibleName 调用,提升 AT-SPI 覆盖率。

覆盖率对比

指标 补全前 补全后
总控件数 65 65
已命名 48 59
缺失 17 6
覆盖率 73.8% 90.8%

修改文件 (7 files, +17 lines)

  • src/controls/linebar.cpp
  • src/editor/showflodcodewidget.cpp
  • src/widgets/ColorSelectWdg.cpp
  • src/widgets/bottombar.cpp
  • src/widgets/ddropdownmenu.cpp
  • src/widgets/pathsettintwgt.cpp
  • src/widgets/window.cpp

验证

  • 本地编译通过(cmake + make 100%)
  • 补全后重新扫描验证覆盖率提升

Summary by Sourcery

Enhancements:

  • Add object and accessible names to previously unnamed controls, menus, actions, and groups to improve AT-SPI accessibility coverage.

Add setObjectName/setAccessibleName calls to interactive widgets
missing accessibility names, improving AT-SPI coverage from 73.8% to 90.8%.

为缺失无障碍名称的交互控件添加 setObjectName/setAccessibleName 调用,
AT-SPI 覆盖率从 73.8% 提升至 90.8%。

Log: 补全文本编辑器 AT-SPI 无障碍名称
Influence: 提升文本编辑器 AT-SPI 无障碍覆盖率,便于辅助工具和自动化测试定位控件。
@deepin-ci-robot

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@deepin-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: re2zero

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sourcery-ai

sourcery-ai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The PR improves AT-SPI coverage from 73.8% to 90.8% by assigning Qt object names and accessible names to 11 previously unnamed controls and related menu components across seven files, with no behavioral changes. Review the chosen naming conventions, especially duplicate or generic names and the lifetime/initialization assumptions for member widgets, menus, actions, and groups.

File-Level Changes

Change Details Files
Add stable object and accessible names to previously unnamed interactive controls to improve AT-SPI discoverability.
  • Name the line-edit clear button, fold-code content editor, color selector button, and window tab bar.
  • Name format actions, dropdown menu components, UTF-8 encoding action, and path-setting button group.
  • Name the main window menu after its actions are initialized.
src/controls/linebar.cpp
src/editor/showflodcodewidget.cpp
src/widgets/ColorSelectWdg.cpp
src/widgets/bottombar.cpp
src/widgets/ddropdownmenu.cpp
src/widgets/pathsettintwgt.cpp
src/widgets/window.cpp

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants