Repository navigation
mintinstall.py: Fix NameError when screenshot metadata can't be read - #518
Open
Amadeus-22 wants to merge 1 commit into
Open
Amadeus-22 wants to merge 1 commit into
Amadeus-22 wants to merge 1 commit into
Conversation
get_screenshot_source_from_metadata() printed ss_path in its GLib.Error handler, but that name doesn't exist in this function. Use the path of the screenshot being queried. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_screenshot_source_from_metadata()catchesGLib.Errorand prints a message usingss_path, which is not defined in that function. Ifquery_info()fails (for example the cached screenshot file is gone), the handler itself raisesNameError: name 'ss_path' is not definedinstead of returningNone, and clicking the screenshot to enlarge it does nothing.The fix uses
screenshot.path, the path that was just queried.Tested on Mint 22.2 by calling the function with a screenshot whose path does not exist:
NameError: name 'ss_path' is not definedCould not retrieve source metadata for screenshot (/nonexistent/shot.png): ...and returnsNone🤖 Generated with Claude Code