fix(spanner): modernize adapter config#511
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #511 +/- ##
==========================================
+ Coverage 71.63% 74.44% +2.81%
==========================================
Files 439 439
Lines 53427 53490 +63
Branches 8460 8464 +4
==========================================
+ Hits 38270 39819 +1549
+ Misses 12654 11048 -1606
- Partials 2503 2623 +120
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
1b86132 to
213310f
Compare
6d4c333 to
6c9cab8
Compare
6c9cab8 to
2fa84aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Spanner adapter config to route current Google Cloud Spanner client, instance, database, session-pool, and request execution options.
Details
min_sessionsbehavior with the session-pool controls used by current Spanner pools, includingsize,target_size,default_timeout, labels, and max age.min_sessionsearly so unsupported pool configuration does not appear to work.retryandtimeoutdriver features and forwards them toexecute_sql(),execute_update(), andbatch_update().Review Notes
This branch is rebased onto the latest
main; the changes are limited to Spanner config routing and the request execution kwargs needed to honor the new driver features.