-
Notifications
You must be signed in to change notification settings - Fork 38
(WIP) Integrate livekit capture #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ladvoc
wants to merge
27
commits into
main
Choose a base branch
from
ladvoc/livekit-capture
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
d70a8de
Point submodule to ladvoc/livekit-capture
ladvoc 691c81f
Define VideoCodec and add video_encoder publish option
ladvoc d59ec72
Add capture protos and LIVEKIT_ENABLE_CAPTURE option
ladvoc 5e481d8
Add capture source requests to FfiClient
ladvoc 4484f37
Add CaptureSource wrapper
ladvoc c6f0fa8
Add capture source integration test
ladvoc 2a9375f
scoped lock
stephen-derosa 592ab3b
working in CI
stephen-derosa aea2e0f
required resolution and explicit demo characteristics
stephen-derosa 6fc46ab
livekit capture: device
stephen-derosa 57e6fe9
PatternVideoSourceConfig
stephen-derosa 1cfd4db
note
stephen-derosa 2816373
clarifying comment on gstreamer version
stephen-derosa 44c6a76
upper case enum alignment
stephen-derosa a70378f
update comments
stephen-derosa 2378c84
complete doxygen
stephen-derosa f0861e1
complete doxygen
stephen-derosa e4bb683
no more optional
stephen-derosa 48a93da
internal api converter
stephen-derosa 0c4a556
rm unneeded local var
stephen-derosa bffaafd
start/stop return bool
stephen-derosa c0c4c3c
use public header
stephen-derosa cbbc4ed
fix deps
stephen-derosa 06723f5
rust hash
stephen-derosa 9c799e0
dep on libjpeg
stephen-derosa ab2cf8f
pass clang for macro
stephen-derosa cdff6dc
rust hash
stephen-derosa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule client-sdk-rust
updated
from 1a477b to 31eeea
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Help me understand the difference in versions between these installs and the one at the top of this file for Windows?
1.0-devvs.1.28.5? Just making sure no surprisesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good callout, I added a clarifying comment. Effectively we are doing this to ensure we go through through each platform’s native package mechanism (linux/mac use latest whereas windows uses an explicit pinned version).