Repository navigation
fix: remove MediaRecorder audio data listener on stop - #478
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
RaphaelFakhri
requested review from
changt,
davidliu,
hiroshihorie and
xianshijing-lk
as code owners
October 18, 2026 11:06
🦋 Changeset detectedLatest commit: 19bbcd9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #477
MediaRecorder.stop()deletes the native audio sink but leaves the JSLK_AUDIO_DATAsubscription thatstart()added in place. Eachstart()adds a new subscription, and every subscription checks the event against the current_reactTag. After a recorder is stopped and started again, all of its subscriptions match the new sink, so every audio chunk is stored once per previousstart(). The second recording comes back with each chunk doubled, the third tripled, and so on. The subscriptions also keep the recorder alive after it is no longer used.unregisterListener()now callsremoveListener(this)and clears_reactTagafter it deletes the native sink. Clearing the tag also stops a secondstop()call from deleting the same native sink again.src/__tests__/MediaRecorder.test.tsmocks the native module, sendsLK_AUDIO_DATAevents throughDeviceEventEmitter, and checks that:main, the second recording returns[4, 5, 6, 4, 5, 6]instead of[4, 5, 6].stop()twice deletes the native sink once. Onmain, it is deleted twice.Both cases fail on
mainand pass with this change.yarn test,yarn lint(no new warnings), andyarn typescriptpass.Changeset included.