feat(lk): env command preserves existing file content unless --overwrite#846
Merged
rektdeckard merged 3 commits intoMay 22, 2026
Merged
Conversation
Contributor
Topherhindman
left a comment
Topherhindman
left a comment
There was a problem hiding this comment.
this seems fine, however, i feel like dotenv files have enough weird cases that it'd be good for us to have some coverage for. some that could be good:
- preserves comments/blank lines
- updates existing keys
- appends missing keys
- keeps
export - handles inline comments
- handles missing destination file
- verifies
overwrite=truestill fully replaces
Contributor
There was a problem hiding this comment.
is this change intentional?
Member
Author
There was a problem hiding this comment.
It is unintentional but permissible 😆
Topherhindman
approved these changes
May 21, 2026
rektdeckard
deleted the
tobiasfried/grw-547-improve-lk-app-env-write-ergonomics
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/livekit/issue/GRW-547/improve-lk-app-env-write-ergonomics
lk app env --writenow preserves existing entries in the target file (upserting only the vars we touch)--overwriteSorry, this was an old ticket that got lost 😅