Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/goofy-hats-stop.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@livekit/rtc-node': minor
---

bump rtc-ffi-bindings to 0.13.1(libwebrtc m150, with WARP enabled by default).
2 changes: 1 addition & 1 deletion packages/livekit-rtc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"dependencies": {
"@datastructures-js/deque": "1.0.8",
"@livekit/mutex": "^1.0.0",
"@livekit/rtc-ffi-bindings": "0.12.73",
"@livekit/rtc-ffi-bindings": "0.13.1",
"@livekit/typed-emitter": "^3.0.0",
"pino": "^9.0.0",
"pino-pretty": "^13.0.0"
Expand Down
17 changes: 10 additions & 7 deletions packages/livekit-rtc/src/tests/e2e_data_streams.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -477,12 +477,13 @@ describeE2E('livekit-rtc data streams e2e', () => {
expect(subscribedReaderCount(receivingRoom!)).toBe(0);

// The read settles rather than hanging. Which way it settles is a race
// the SDK doesn't control: the native side emits a clean end-of-stream
// when the room drops the stream (livekit-ffi `read_incremental` sends
// `eos { error: None }` once the channel closes), so either that lands
// first and the read returns the chunks buffered so far, or disconnect
// cleanup errors the stream first and the read reports that. Python is
// deterministic here because it injects a synthetic error end-of-stream.
// the SDK doesn't control: the native side aborts in-flight streams when
// the room shuts down (livekit-ffi sends `eos` with a
// `StreamError::AbnormalEnd`), while disconnect cleanup errors the stream
// from the JS side. Whichever lands first wins. CI has also seen a clean
// `eos` land first, ending the read with the chunks buffered so far;
// that's unexpected after the native abort-on-shutdown change and is
// still being investigated, so it's tolerated here for now.
const readResult = await withTimeout(
reader.readAll().then(
(text) => ({ text }),
Expand All @@ -492,7 +493,9 @@ describeE2E('livekit-rtc data streams e2e', () => {
'Timed out reading a reader whose room disconnected',
);
if ('err' in readResult) {
expect(String(readResult.err)).toMatch(/Disconnected while receiving/);
expect(String(readResult.err)).toMatch(
/Disconnected while receiving|stream closed abnormally: Data stream connection closed/,
);
} else {
expect('buffered data'.startsWith(readResult.text)).toBe(true);
}
Expand Down
50 changes: 25 additions & 25 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading