Skip to content

Update dependency brace-expansion@<1.1.21 to v5 #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update dependency brace-expansion@<1.1.21 to v5 #762

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 2 additions & 15 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ catalog:

# Security: force patched versions of transitive deps that parents pin to vulnerable versions.
overrides:
brace-expansion@<1.1.21: ^1.1.21
brace-expansion@<1.1.21: ^5.0.0

@devin-ai-integration devin-ai-integration Bot Oct 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Legacy glob matching fails across tooling

With brace-expansion forced to v5, minimatch@3.1.5 cannot call its ESM-only dependency as a CommonJS function. ESLint and glob 7 fail to match files, breaking workspace linting.

Learn more

The lockfile links minimatch@3.1.5 to brace-expansion 5.0.12. That minimatch release loads brace-expansion with require() and invokes the returned value as a function. Brace-expansion changed to ESM in v3, so the 5.x export is not the callable CommonJS value minimatch expects. ESLint and glob 7 both depend on minimatch 3. Linting files with brace patterns and legacy glob calls fail; on Node versions that cannot require ESM, loading minimatch itself fails.

Example: Running pnpm lint on Node 24 processes an ESLint glob such as **/*.{ts,tsx}. Minimatch 3 invokes the ESM namespace as a function instead of expanding the braces, so the lint run fails.

Recommended fix: Keep the override for 1.x consumers on patched brace-expansion 1.1.21, or update all consumers of minimatch 3 to releases compatible with brace-expansion 5 before overriding their dependency. Test lint and glob matching under the repository's supported Node versions.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

brace-expansion@>=2.0.0 <2.1.7: ^2.1.7
brace-expansion@>=4.0.0 <5.0.12: ^5.0.12
glob@>=10.2.0 <10.5.0: ^10.5.0
Expand Down
Loading