Skip to content

feat: add issue_count to SimulationRun - #1756

Open
u9g wants to merge 2 commits into
mainfrom
jason/simulation-run-issue-count
Open

feat: add issue_count to SimulationRun#1756
u9g wants to merge 2 commits into
mainfrom
jason/simulation-run-issue-count

Conversation

@u9g

@u9g u9g commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

SimulationRun carries no issue count, so the simulations runs list can only fill its "Issues detected" column by zstd-decompressing and unmarshalling summary_zstd once per row.

Adds SimulationRun.issue_count (optional int32, field 21), denormalised at summarize time. Optional rather than plain: absent and 0 mean different things — "never summarized" versus "summarized, found nothing" — and a List response can carry the count without carrying the summary blob.

Consumers

Both pin this commit and need it merged first:

  • livekit/agents-private, branch jason/sim-list-metrics: writes the count when the summarize result lands, returns it on list and get
  • livekit/web, branch jason/sim-list-issue-count: reads it on the runs list, falling back to decoding the summary blob for runs summarized before the field shipped

Note for review

The regenerated Go stubs also record protoc v5.28.2 where main had v7.35.1. That is a side effect of the local toolchain, not an intended change — worth regenerating with the version main uses before merging.

u9g and others added 2 commits August 31, 2026 15:15
Present only once a summary landed, so List responses can carry the
count without the summary blob; absent and 0 stay distinguishable.
@changeset-bot

changeset-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 42648b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant