feat: add issue_count to SimulationRun - #1756
Open
u9g wants to merge 2 commits into
Open
Conversation
Present only once a summary landed, so List responses can carry the count without the summary blob; absent and 0 stay distinguishable.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SimulationRuncarries no issue count, so the simulations runs list can only fill its "Issues detected" column by zstd-decompressing and unmarshallingsummary_zstdonce per row.Adds
SimulationRun.issue_count(optional int32, field 21), denormalised at summarize time. Optional rather than plain: absent and 0 mean different things — "never summarized" versus "summarized, found nothing" — and a List response can carry the count without carrying the summary blob.Consumers
Both pin this commit and need it merged first:
jason/sim-list-metrics: writes the count when the summarize result lands, returns it on list and getjason/sim-list-issue-count: reads it on the runs list, falling back to decoding the summary blob for runs summarized before the field shippedNote for review
The regenerated Go stubs also record
protoc v5.28.2where main hadv7.35.1. That is a side effect of the local toolchain, not an intended change — worth regenerating with the version main uses before merging.