agent simulation: filter the run list and counts by mode - #1762
Open
u9g wants to merge 3 commits into
Open
Conversation
`SimulationRun` carries `mode`, but `List.Request` and `Counts.Request` could only narrow by status, window and agent name, so the dashboard's runs list had no way to show only text or only voice runs. Both requests take the same optional `mode`, applied the same way, so the histogram above the list keeps counting the rows the list shows.
|
theomonnom
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
optional SimulationMode modetoSimulationRun.List.Request(field 7) andSimulationRun.Counts.Request(field 6).SimulationRunalready carriesmode, but the list and counts requests could only narrow by status, time window and agent name, so the cloud dashboard's runs list can show a Mode column (livekit/web#5954) but cannot filter on it. Both requests take the filter so the histogram above the list keeps counting exactly the rows the list shows, the same waystatusandagent_namealready do.Semantics for the server: unset means every mode.
SimulationRun.modedocuments unspecified as TEXT, so aSIMULATION_MODE_TEXTfilter must match runs stored with eitherUNSPECIFIEDorTEXT.No wrapper change is needed in backend-common:
cloud_agent_simulation_run.protopasses these through asinner_request. Follow-ups after this lands are the backend query and the dashboard filter control.