Update github workflows - #619
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
a453ed8 to
d5f2328
Compare
d5f2328 to
eb4145c
Compare
eb4145c to
bf4340b
Compare
bf4340b to
06c9eff
Compare
ab5449c to
c3fa151
Compare
renovate
Bot
changed the title
c3fa151 to
41f3351
Compare
41f3351 to
f6ca3b4
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
c511dc1 to
b8315f5
Compare
b8315f5 to
db8310b
Compare
2a07107 to
bc90174
Compare
3b0b3d5 to
512f10e
Compare
There was a problem hiding this comment.
🔴 Type-checking job downloads native library into a nonexistent Python folder after version upgrade
The native library download destination is hardcoded to a Python 3.9 folder (.venv/lib/python3.9/... at .github/workflows/check-types.yml:38) even though the job now sets up Python 3.14, so the files land in the wrong place and are never picked up.
Impact: The Check Types CI job can no longer find the downloaded library and fails or type-checks against a broken install.
Version mismatch between setup-python and hardcoded venv path
The step at .github/workflows/check-types.yml:20-23 was changed to install Python 3.14, but the download step at .github/workflows/check-types.yml:38 still writes to .venv/lib/python3.9/site-packages/livekit/rtc/resources. Since uv sync (.github/workflows/check-types.yml:32) creates .venv using the active 3.14 interpreter, the real site-packages path is .venv/lib/python3.14/site-packages/.... The download_ffi.py --output path therefore points to a directory that is not on the interpreter's import path, so livekit.rtc resources are missing when mypy runs at .github/workflows/check-types.yml:41. Previously (with Python 3.9) the two matched. The path must track the configured Python minor version.
(Refers to line 38)
Prompt for agents
In .github/workflows/check-types.yml the 'Set up Python' step was bumped to python-version 3.14, but the 'Download ffi' step (line 38) still hardcodes the output path .venv/lib/python3.9/site-packages/livekit/rtc/resources. Because uv sync creates the .venv using the 3.14 interpreter, the actual site-packages directory is .venv/lib/python3.14/site-packages, so the ffi resources are downloaded into a directory that is not on the import path and mypy will not find them. Fix by making the path track the configured Python version, e.g. derive the site-packages directory dynamically (using `uv run python -c 'import livekit.rtc, os; print(...)'` or `python -c 'import sysconfig'`) instead of hardcoding python3.9. Also consider updating the stale step name 'Set up Python 3.9'.
Was this helpful? React with 👍 or 👎 to provide feedback.
4518161 to
904ad17
Compare
904ad17 to
c7e73ff
Compare
e5273c3 to
980dcd3
Compare
980dcd3 to
26701f7
Compare
425ee38 to
e7ed0fb
Compare
e7ed0fb to
01a6da4
Compare
Generated by renovateBot
01a6da4 to
f708b95
Compare
This PR contains the following updates:
9c091bb→3d3c42e3.12→3.143.9→3.143.11→3.143.10→3.14Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
actions/python-versions (python)
v3.14.7: 3.14.7Compare Source
Python 3.14.7
v3.14.6: 3.14.6Compare Source
Python 3.14.6
v3.14.5: 3.14.5Compare Source
Python 3.14.5
v3.14.4: 3.14.4Compare Source
Python 3.14.4
v3.14.3: 3.14.3Compare Source
Python 3.14.3
v3.14.2: 3.14.2Compare Source
Python 3.14.2
v3.14.1: 3.14.1Compare Source
Python 3.14.1
v3.14.0: 3.14.0Compare Source
Python 3.14.0
v3.13.15: 3.13.15Compare Source
Python 3.13.15
v3.13.14: 3.13.14Compare Source
Python 3.13.14
v3.13.13: 3.13.13Compare Source
Python 3.13.13
v3.13.12: 3.13.12Compare Source
Python 3.13.12
v3.13.11: 3.13.11Compare Source
Python 3.13.11
v3.13.10: 3.13.10Compare Source
Python 3.13.10
v3.13.9: 3.13.9Compare Source
Python 3.13.9
v3.13.8: 3.13.8Compare Source
Python 3.13.8
v3.13.7: 3.13.7Compare Source
Python 3.13.7
v3.13.6: 3.13.6Compare Source
Python 3.13.6
v3.13.5: 3.13.5Compare Source
Python 3.13.5
v3.13.4: 3.13.4Compare Source
Python 3.13.4
v3.13.3: 3.13.3Compare Source
Python 3.13.3
v3.13.2: 3.13.2Compare Source
Python 3.13.2
v3.13.1: 3.13.1Compare Source
Python 3.13.1
v3.13.0: 3.13.0Compare Source
Python 3.13.0
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.