Repository navigation
fix(tests): fix mypy errors in test_basic.py and reuse utils helpers - #913
Merged
Merged
Conversation
mypy (Check Types) failed on main after #641 with no-untyped-def, no-untyped-call and untyped-decorator errors. Annotate skip_if_no_credentials() like tests/utils.py does, and type the event callback's *args/**kwargs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cloudwebrtc
requested review from
changt,
lukasIO and
xianshijing-lk
as code owners
October 30, 2026 01:12
Contributor
|
👋 This PR has no changeset. If it should be released, add a markdown file under ---
"livekit-rtc": patch
---
Short description of the change, used in the release notes.
If this change doesn't need a release (docs, CI, tests), you can ignore this comment. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Replace the local copies of skip_if_no_credentials, create_token, unique_room_name and the wait/connect/event helpers with the shared ones in tests/utils.py. expect_room_event now unregisters its handler once the event fires. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
cloudwebrtc
changed the title
xianshijing-lk
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check Types fails on
mainsince #641 (run):tests/utils.py. It now importsskip_if_no_credentials,create_token,unique_room_name,wait_until,connect_room,ensure_rooms_all_connected,ensure_track_subscribed,expect_room_eventandawait_eventfrom there, liketest_dc.pydoes, which also removes the untyped definitionspub.trackis setTest-only change, so no changeset.
uv run mypy livekit-protocol livekit-api livekit-rtcand ruff pass locally; the E2E test itself was not run (no LiveKit credentials locally).🤖 Generated with Claude Code