Skip to content

Sxian/clt 2940/improve error messages for tlsca certificate failures in region#1114

Open
xianshijing-lk wants to merge 5 commits into
mainfrom
sxian/CLT-2940/improve-error-messages-for-tlsca-certificate-failures-in-region
Open

Sxian/clt 2940/improve error messages for tlsca certificate failures in region#1114
xianshijing-lk wants to merge 5 commits into
mainfrom
sxian/CLT-2940/improve-error-messages-for-tlsca-certificate-failures-in-region

Conversation

@xianshijing-lk
Copy link
Copy Markdown
Contributor

Before you submit your PR

Make sure the following is true before submitting your PR:

  • I have read the contributing guidelines and validated that this PR will be accepted.
  • I have read and followed the principles regarding breaking changes, testing, and code quality.

PR description

  1. Improved error chain preservation - Added error_with_chain() helper that walks the full std::error::Error::source() chain, so errors now show:
    failed to retrieve region info: error sending request for url (...): error trying to connect: invalid peer certificate: UnknownIssuer
  2. Added documentation - Added doc comments to SignalError::RegionError explaining common causes and fixes (install ca-certificates or use rustls-tls-webpki-roots feature)
  3. Added TLS feature documentation in Cargo.toml - Documented the TLS features and highlighted rustls-tls-webpki-roots as the recommended option for container deployments
  4. Added unit tests - 8 new tests verifying the error chain is properly preserved and surfaced

Tests:
cargo test -p livekit-api --features signal-client-tokio region

Breaking changes

N/A

MSRV

N/A

Testing

cargo test -p livekit-api --features signal-client-tokio region

Async

n/A

xianshijing-lk and others added 3 commits May 21, 2026 11:50
Add new_frame_number variable to capture the interrupting frame number
before the packet is moved. This fixes the undefined variable error
in the test_interrupted test assertion.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@xianshijing-lk xianshijing-lk requested a review from ladvoc as a code owner May 21, 2026 20:59
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2026

Changeset

The following package versions will be affected by this PR:

Package Bump
livekit-api patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant