Bumping emiago/sipgo - #829
Open
genseric-ghiro wants to merge 2 commits into
Open
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| github.com/docker/go-connections v0.7.0 // indirect | ||
| github.com/docker/go-units v0.5.0 // indirect | ||
| github.com/emiago/sipgo v1.4.0 | ||
| github.com/emiago/sipgo v1.5.0 |
There was a problem hiding this comment.
🟡 Oversized message poisons its connection
When a streaming message exceeds 65,535 bytes, v1.5.0 returns ErrMessageTooLarge, but parseStream keeps reading. Lost framing can reject every later call on that connection.
Prompt for agents
The v1.5.0 stream parser returns ErrMessageTooLarge for an incomplete oversized message after discarding its buffered state, and its contract requires the caller to close the connection because no message boundary remains. The TCP/TLS read loop in the pinned github.com/livekit/sipgo version, transport/tcp.go readConnection/parseStream, logs every non-partial parser error and continues. Update that transport integration to propagate ErrMessageTooLarge and terminate the read loop/connection, or consume a livekit/sipgo revision that implements the v1.5.0 parser contract. Add a TCP stream test that sends an oversized incomplete message followed by a valid SIP request and verifies that the connection closes rather than parsing trailing bytes.
Was this helpful? React with 👍 or 👎 to provide feedback.
Contributor
Author
There was a problem hiding this comment.
Yes, this is the plan, to do in a separate PR
alexfish8
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary