fix: sanitize subprocess call in launch_all_serve.py#3865
Open
orbisai0security wants to merge 1 commit into
Open
fix: sanitize subprocess call in launch_all_serve.py#3865orbisai0security wants to merge 1 commit into
orbisai0security wants to merge 1 commit into
Conversation
Automated security fix generated by Orbis Security AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
fastchat/serve/launch_all_serve.py.Vulnerability
V-001fastchat/serve/launch_all_serve.py:252Description: Six subprocess.run() calls in launch_all_serve.py use shell=True with string arguments constructed from configuration values, environment variables, or command-line arguments. When shell=True is used, the entire string is passed to /bin/sh for interpretation, meaning any shell metacharacters (;, |, &&, $(), backticks) in the input strings will be executed as separate OS commands. If any portion of worker_sh, controller_sh, or server_sh is derived from user-supplied or externally-controlled input, an attacker can inject arbitrary operating system commands.
Changes
fastchat/serve/launch_all_serve.pyVerification
Automated security fix by OrbisAI Security