Fix create_completion capping all batch prompts to the shortest context's max_tokens#3867
Open
Chessing234 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
In
create_completion, a pre-generation loop validates context length for each prompt:check_lengthreturnsmin(request.max_tokens, context_len - token_num)— the maximum tokens that can be generated given that prompt's context usage. The mutationrequest.max_tokens = max_tokenscarries this reduced value into subsequent iterations.Root cause
If prompt A is long (leaves 148 tokens available),
request.max_tokensis reduced from 1000 to 148. Prompt B (short, leaves 1948 tokens available) is then checked against the already-reduced 148 and the generation loop uses 148 for both. Prompt B is silently limited to 148 tokens even though the user requested 1000 and the context easily fits them.Why the fix is correct
Each prompt's available tokens are a function of its own length, not of other prompts in the batch.
check_lengthalready raises an error if a prompt overflows context, so the mutation's validation purpose is redundant. Without the mutation, generation usesrequest.max_tokens(the user's requested value) for all prompts; model workers naturally cap output at available context, producing correct results independently per prompt.