Repository navigation
Display captured attachments locally before upload - #83
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
RCmerci
force-pushed
the
fix/capture-local-assets-20261016
branch
from
October 16, 2026 08:55
86a9fbf to
ac42df9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capture attachments now display their local original in the saved Timeline before upload, and continue to use the ordinary cache after restart and publication instead of downloading their own upload.
Publish verified staged originals into the scoped asset cache using the existing durable upload intent. Admit current Capture receipts, hand temporary previews to normal file leases after the final open-preview owner closes, refresh pending metadata demands, and clean up matching cancellation. Private lookup/fetch tickets keep remote Fetch dependent on an explicit remote version. The two spec changes were explicitly approved; no new durable state, worker callback API, dependency, or Dune changes are introduced.
Validation
ac42df90f7de684b894ce9c6a23220a4797ed181, including all targets/native embed and the full regression suite.c49728e; all four Capture patches are unchanged by range-diff.1e38f64644cdd49081004722cd9dd43759b2aaafwas checked without rewriting this head: conflict-free synthetic merge tree7aff10eca7b91519c45bec7c14592d02cdf58679, with Application 115, graph runtime 140, routes, adaptive, media/runtime and source-boundary checks passing. No product change, rebase, new full CI or Simulator run was needed; the full remote CI above remains scoped to the PR82 base.@allplusapp/native_embed.exe.obuild and completedune runtestpassed on the PR82 base: 861 Alcotest cases plus media/runtime and source-boundary checks, including Application 111. Five new preview-lifetime cases were verified RED then GREEN. The worker lifecycle test uses the publicTransfer.Lookupwrapper for the split lookup ticket. The decision document validates; the repository-wide document check retains three pre-existing missing-section failures.ac42df90f7de684b894ce9c6a23220a4797ed181and found no evidence-backed issue. It independently reran Application 111, worker reducer 16, worker runner 25, transfer 20, cache 11, media/runtime and source-boundary checks; it reused matching binaries without a fresh build or GUI run.Acceptance limits
The full Simulator run covered the pre-preview-fix implementation (
72c5e76, identical business bytes at initial rebased head2176592). The final narrow preview-lifetime fix is covered by public runtime regressions; no additional Simulator build was run. The Simulator run uses an experimental host ARM64 OCaml restamp (cross_abi_validated=false), with a test-only memory-secret host and controlled loopback service. It does not establish full iOS cross-compilation/ABI or real cloud-service acceptance. No phone or private graph was used. The existing warm-start authentication reconnect issue was worked around through ordinary product graph switching and is outside this change.