Skip to content

Align Timeline tags and remove block deletion Undo - #86

Merged
RCmerci merged 6 commits into
mainfrom
codex/timeline-tags-direct-delete-20261016
Oct 16, 2026
Merged

RCmerci merged 6 commits into
mainfrom
codex/timeline-tags-direct-delete-20261016

Conversation

@RCmerci

@RCmerci RCmerci commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Timeline items now align tags to the right, show the first three titles in their existing order, and display the exact remaining count as +N. Long names wrap using native OCaml LUI text layout; Detail continues to show all tags. The change reuses the existing hydrated titles without widening graph reads.

Deleting a block now submits immediately with the existing revision precondition. The content stays visible while the request is pending, duplicate deletion is disabled, and successful completion removes the block and descendants. Failure keeps the content and shows the reason and retry guidance in Details. Remove the complete Undo feature: staging/restoration state, events, deadlines/timer callbacks, notice wire protocol, Swift presenter/queue, and obsolete staging tests, without compatibility wrappers. The protected interface changes follow the two explicitly approved exact diffs.

Validation:

  • Incremental dune build @all app/native_embed.exe.o -j2 and full dune runtest --force -j2: 876 Alcotest cases and 87 custom PASS checks, including the PR83/PR84 integration and public page/composer ownership regression.
  • Tag and delete regressions were observed failing before implementation. Narrow mounted public-view/Worker tests cover immediate dispatch, revision preconditions, pending retained content, success/failure, duplicate suppression, Details/retry and no notice requests. Public Timeline/Routes tests retain normal deletion and late-read ownership checks.
  • OCaml/Swift platform-wire interoperability and native macOS pure/Worker harnesses pass.
  • Actual isolated iPhone 13 mini Simulator: 5/5 XCTest scenarios, zero failures (67.439s), covering tags 0/1/3/4/9, long names, narrow screen, status/assets, successful deletion, failure Details/retry, pending action disabled, and largest accessibility text. All deletion fixtures are in memory; no personal graph was deleted. Final screenshot LibraryID: libfile_01b78e91e8ec81918a5f1d672cca0943.
  • Simulator evidence uses an experimental host-restamped OCaml probe with cross_abi_validated=false; it does not establish full production iOS cross-compilation/ABI or phone acceptance. The unified builder reports built at source 02f36cf; final 8f3d3c6 adds only the completed decision document, with all 318 native-source hashes unchanged. Matching existing Swift/LUI inputs were reused; no dependency rebuild or CI cold/hot experiment was repeated.
  • git diff --check, feature-symbol residue scan, and this decision document validate. Full spec-dev-tool check --all still reports three unchanged main documents missing required sections: 2026-10-06-timeline-soft-scroll-edge.md, 2026-10-09-favorites-native-soft-header.md, and 2026-09-28-bottom-lui-capsules.md.

Based on verified main bb2b9fbd8d0e090e90b5ab7f1b0e990ce0e09169. No Dune, lock, or spec/ changes. Phone installation and merging are outside this PR publication.

Final publication checks:

  • Independent read-only session using journal-code-review reviewed exact head 8f3d3c604a44bea11a710d71093012794fdbc22c: no evidenced defects introduced by this PR.
  • Journal CI run 38891668787 succeeded for that exact head, including all-target/native-embed build, full regression, final input verification and cache sealing. WIP check also passed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T11:13:45.031913Z 8f3d3c6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@RCmerci
RCmerci merged commit d37064c into main Oct 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant