Repository navigation
Align Timeline tags and remove block deletion Undo - #86
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Timeline items now align tags to the right, show the first three titles in their existing order, and display the exact remaining count as
+N. Long names wrap using native OCaml LUI text layout; Detail continues to show all tags. The change reuses the existing hydrated titles without widening graph reads.Deleting a block now submits immediately with the existing revision precondition. The content stays visible while the request is pending, duplicate deletion is disabled, and successful completion removes the block and descendants. Failure keeps the content and shows the reason and retry guidance in Details. Remove the complete Undo feature: staging/restoration state, events, deadlines/timer callbacks, notice wire protocol, Swift presenter/queue, and obsolete staging tests, without compatibility wrappers. The protected interface changes follow the two explicitly approved exact diffs.
Validation:
dune build @all app/native_embed.exe.o -j2and fulldune runtest --force -j2: 876 Alcotest cases and 87 custom PASS checks, including the PR83/PR84 integration and public page/composer ownership regression.libfile_01b78e91e8ec81918a5f1d672cca0943.cross_abi_validated=false; it does not establish full production iOS cross-compilation/ABI or phone acceptance. The unified builder reportsbuiltat source02f36cf; final8f3d3c6adds only the completed decision document, with all 318 native-source hashes unchanged. Matching existing Swift/LUI inputs were reused; no dependency rebuild or CI cold/hot experiment was repeated.git diff --check, feature-symbol residue scan, and this decision document validate. Fullspec-dev-tool check --allstill reports three unchanged main documents missing required sections:2026-10-06-timeline-soft-scroll-edge.md,2026-10-09-favorites-native-soft-header.md, and2026-09-28-bottom-lui-capsules.md.Based on verified main
bb2b9fbd8d0e090e90b5ab7f1b0e990ce0e09169. No Dune, lock, orspec/changes. Phone installation and merging are outside this PR publication.Final publication checks:
journal-code-reviewreviewed exact head8f3d3c604a44bea11a710d71093012794fdbc22c: no evidenced defects introduced by this PR.