Skip to content

Upgrade Electron to 41.7.1#30

Merged
tiensonqin merged 1 commit into
version/filefrom
logseq/upgrade-electron-42
May 28, 2026
Merged

Upgrade Electron to 41.7.1#30
tiensonqin merged 1 commit into
version/filefrom
logseq/upgrade-electron-42

Conversation

@tiensonqin

@tiensonqin tiensonqin commented May 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Upgrade Electron from 38.4.0 to 41.7.1, the newest Electron line verified to package successfully with the app native dependencies.
  • Update Electron packaging dependencies: better-sqlite3 to 12.10.0 and node-abi resolution to 4.31.0.
  • Regenerate root and static Yarn lockfiles for the updated Electron packaging dependency graph.

Why not Electron 42.3.0

Electron 42.3.0 resolves with node-abi 4.31.0, but better-sqlite3 12.10.0 still fails to compile against Electron 42 V8 headers with ExternalPointerTypeTag-related native addon errors. Electron 41.7.1 is the newest release verified to rebuild better-sqlite3 and complete packaging.

Validation

  • node-abi lookup for Electron 41.7.1 returns ABI 145
  • yarn install --frozen-lockfile --ignore-scripts --non-interactive
  • cd static && yarn install --frozen-lockfile --ignore-scripts --non-interactive
  • cd static && yarn electron-rebuild -v 41.7.1 -f -w better-sqlite3
  • git diff --check
  • yarn release-electron
  • Launched packaged app from static/out/Logseq-OG-darwin-arm64/Logseq-OG.app and added two blocks in a temporary graph with Playwright

Artifacts

  • static/out/make/Logseq-OG.dmg
  • static/out/make/zip/darwin/arm64/Logseq-OG-darwin-arm64-1.0.0.zip

@tiensonqin tiensonqin changed the title [codex] Upgrade Electron to 42.3.0 chore: Upgrade Electron to 42.3.0 May 28, 2026
@tiensonqin tiensonqin marked this pull request as ready for review May 28, 2026 12:02
Copilot AI review requested due to automatic review settings May 28, 2026 12:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the desktop app’s Electron runtime from 38.4.0 to 42.3.0, updating the associated packaging/rebuild configuration and regenerating lockfiles to reflect the new dependency graph.

Changes:

  • Bump Electron to 42.3.0 in root package.json and resources/package.json (including the Electron resolution).
  • Update the rebuild:all script to target Electron 42.3.0.
  • Regenerate root and static/ Yarn lockfiles for the updated Electron dependency tree (notably updating @electron/get and related transitive deps).

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.

File Description
package.json Updates the root app’s Electron dependency to 42.3.0.
resources/package.json Updates packaging-time Electron version/resolution and rebuild script version.
yarn.lock Regenerates the root lockfile for Electron 42.3.0 and updated transitive dependencies.
static/yarn.lock Regenerates the static lockfile used during CI/e2e packaging steps for Electron 42.3.0.
Comments suppressed due to low confidence (1)

resources/package.json:69

  • The current resolutions include wrap-ansi/strip-ansi pins that can force versions that do not satisfy downstream semver ranges after the Electron upgrade (static/yarn.lock shows wrap-ansi@^8.x and strip-ansi@^7.x being resolved to older majors). This can lead to runtime failures in CLI deps (e.g., @isaacs/cliui). Consider updating these resolutions to compatible majors, or pinning the dependent packages to versions that match the forced majors, so installs don’t rely on incompatible overrides.
  "resolutions": {
    "**/electron": "42.3.0",
    "**/node-abi": "4.14.0",
    "**/node-gyp": "12.0.0",
    "string-width": "4.2.0",
    "wrap-ansi": "^7.0.0",
    "strip-ansi": "^6.0.1"
  }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread resources/package.json Outdated
@tiensonqin tiensonqin force-pushed the logseq/upgrade-electron-42 branch from 2e1f2f8 to efb87bb Compare May 28, 2026 12:44
@tiensonqin tiensonqin changed the title chore: Upgrade Electron to 42.3.0 [codex] Upgrade Electron to 41.7.1 May 28, 2026
@tiensonqin tiensonqin changed the title [codex] Upgrade Electron to 41.7.1 Upgrade Electron to 41.7.1 May 28, 2026
@tiensonqin tiensonqin merged commit 6e7afa8 into version/file May 28, 2026
12 checks passed
@tiensonqin tiensonqin deleted the logseq/upgrade-electron-42 branch May 28, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants