Upgrade Electron to 41.7.1#30
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Upgrades the desktop app’s Electron runtime from 38.4.0 to 42.3.0, updating the associated packaging/rebuild configuration and regenerating lockfiles to reflect the new dependency graph.
Changes:
- Bump Electron to 42.3.0 in root
package.jsonandresources/package.json(including the Electron resolution). - Update the
rebuild:allscript to target Electron 42.3.0. - Regenerate root and
static/Yarn lockfiles for the updated Electron dependency tree (notably updating@electron/getand related transitive deps).
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates the root app’s Electron dependency to 42.3.0. |
| resources/package.json | Updates packaging-time Electron version/resolution and rebuild script version. |
| yarn.lock | Regenerates the root lockfile for Electron 42.3.0 and updated transitive dependencies. |
| static/yarn.lock | Regenerates the static lockfile used during CI/e2e packaging steps for Electron 42.3.0. |
Comments suppressed due to low confidence (1)
resources/package.json:69
- The current resolutions include wrap-ansi/strip-ansi pins that can force versions that do not satisfy downstream semver ranges after the Electron upgrade (static/yarn.lock shows wrap-ansi@^8.x and strip-ansi@^7.x being resolved to older majors). This can lead to runtime failures in CLI deps (e.g., @isaacs/cliui). Consider updating these resolutions to compatible majors, or pinning the dependent packages to versions that match the forced majors, so installs don’t rely on incompatible overrides.
"resolutions": {
"**/electron": "42.3.0",
"**/node-abi": "4.14.0",
"**/node-gyp": "12.0.0",
"string-width": "4.2.0",
"wrap-ansi": "^7.0.0",
"strip-ansi": "^6.0.1"
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2e1f2f8 to
efb87bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why not Electron 42.3.0
Electron 42.3.0 resolves with node-abi 4.31.0, but better-sqlite3 12.10.0 still fails to compile against Electron 42 V8 headers with ExternalPointerTypeTag-related native addon errors. Electron 41.7.1 is the newest release verified to rebuild better-sqlite3 and complete packaging.
Validation
Artifacts