Skip to content

perf: fused emit for no-split add and non-rebalancing remove #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiensonqin merged 2 commits into from
Oct 10, 2026
Merged

perf: fused emit for no-split add and non-rebalancing remove #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4a8ca5
perf: fuse no-split add path for leaves and branches
tiensonqin Oct 10, 2026
b4c97e3
remove: fused emit for branch child replacement without rebalance
tiensonqin Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 45 additions & 5 deletions lib/persistent_sorted_set.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,7 +826,21 @@ and add_to_node storage settings order_cmp equality_cmp key_cmp value = function
| `Found _ -> Tree_edit_unchanged
| `Insert index ->
let inserted = array_insert_len values len index value in
Tree_edit_changed (add_leaf_refs settings ?address inserted))
if len < settings.branching_factor then
(* common case: the leaf does not split, emit it directly
instead of going through the generic chunking pipeline *)
Tree_edit_changed
[
( inserted.(len),
Node.Leaf
{
values = inserted;
len = len + 1;
address;
dirty = true;
} );
]
else Tree_edit_changed (add_leaf_refs settings ?address inserted))
| Node.Branch { keys; children; address; _ } -> (
let index = find_child_index key_cmp value keys in
match
Expand All @@ -835,8 +849,22 @@ and add_to_node storage settings order_cmp equality_cmp key_cmp value = function
with
| Tree_edit_unchanged -> Tree_edit_unchanged
| Tree_edit_changed [ (key, child) ] ->
branch_replace_one settings ?address keys children index key child
|> fun changed -> Tree_edit_changed changed
if Array.length keys <= settings.branching_factor then (
(* common case: the branch does not split, replace the child
in place and emit the branch directly *)
let keys = Array.copy keys in
let children = Array.copy children in
keys.(index) <- key;
children.(index) <- child;
Tree_edit_changed
[
( keys.(Array.length keys - 1),
Node.Branch { keys; children; address; dirty = true } );
])
else
branch_replace_one settings ?address keys children index key
child
|> fun changed -> Tree_edit_changed changed
| Tree_edit_changed changed ->
let keys, children = branch_splice_one keys children index changed in
branch_refs_of_arrays ?first_address:address settings keys children
Expand Down Expand Up @@ -904,8 +932,20 @@ and remove_from_node storage settings order_cmp equality_cmp key_cmp value =
with
| Some changed -> changed
| None ->
branch_replace_one settings ?address keys children index
key child)
if Array.length keys <= settings.branching_factor then (
(* common case: the child stays a single node, replace
it in place instead of rebuilding the branch *)
let keys = Array.copy keys in
let children = Array.copy children in
keys.(index) <- key;
children.(index) <- child;
[ ( keys.(Array.length keys - 1)
, Node.Branch
{ keys; children; address; dirty = true } )
])
else
branch_replace_one settings ?address keys children
index key child)
in
Tree_edit_changed changed
| Tree_edit_changed changed ->
Expand Down
Loading