Update Trio v0.2 message#97
Open
MikePlante1 wants to merge 2 commits into
Open
Conversation
Update the message text in src/BuildTrio.sh (the source of truth) rather than the generated BuildTrio.sh, and regenerate the output file via build.sh. Also rename special_message_0.2_to_0.7 to special_message_0.2_migration so the function name does not reference a specific version number.
Member
|
I noticed the change was made directly in BuildTrio.sh, but that file is actually generated. There is a build.sh in the repo that assembles the final scripts from source files in src/. The one to edit is src/BuildTrio.sh, then you run ./build.sh BuildTrio.sh to regenerate the output. I went ahead and pushed a fix to your branch with the changes moved to the right place. Also renamed the function from special_message_0.2_to_0.7 to special_message_0.2_migration. The PR should be good to merge now. Also changed target to main, dev is not used anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid having to update the script every time Trio's main branch gets updated, this just removes the specific version number from the message.