Repository navigation
Conversation
Pull Request Test Coverage Report for Build 17044955138Details
💛 - Coveralls |
aaqilniz
marked this pull request as ready for review
September 6, 2025 18:04
Member
|
@aaqilniz, thanks for the PR. Could you please add tests? Thanks. |
aaqilniz
marked this pull request as draft
October 18, 2026 04:41
Signed-off-by: Muhammad Aaqil <aaqilcs102@gmail.com>
Signed-off-by: Muhammad Aaqil <aaqilcs102@gmail.com>
aaqilniz
force-pushed
the
fix/pass-options
branch
from
October 31, 2026 04:31
c231cb7 to
fcc2690
Compare
Signed-off-by: Muhammad Aaqil <aaqilcs102@gmail.com>
aaqilniz
marked this pull request as ready for review
October 31, 2026 05:03
Contributor
Author
|
Hi, @dhmlau. Can you please have a look at the PR now? I have added tests to verify the changes. Thanks. |
Open
5 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
defineCrudRestControllerto forward the controller-level options configuration to all underlying repository methods.Previously, none of the CRUD REST controller methods were passing the options parameter down to their respective repository calls, meaning any configuration, transaction contexts, or execution options available at the controller level were entirely dropped.
Changes Made
Updated all generated CRUD controller methods that were not forwarding the options to forward the closure-scoped options parameter to the corresponding repository methods at their correct argument offsets.
Added unit tests verifying correct options propagation and argument positioning across repository method calls.
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈