Repository navigation
fix(turn): preserve missing-lineage contract errors - #7618
xyx2002OvO wants to merge 1 commit into
Conversation
Signed-off-by: Tartar <xiaoyx67@mail2.sysu.edu.cn>
67e7662 to
ab0e378
Compare
这个 PR 在当前 main 上已经过时,而且会与 #7523 刚定下的契约冲突复核方式:在当前 1. 本 PR 针对的那条红项在当前 main 上已经不存在了。 #7523 把 2. 更重要的是:这个 PR 会把 #7523 明确修正过的契约改回去。 #7523 的说明里写得很清楚:
重写后的断言是: assert payload["ok"] is (not invalid_signature)
assert payload["route"]["kind"] == ("contract_error" if invalid_signature else "blocked")也就是签名合法但没有 Todo → 本 PR 的改动把 3. 实测证据。 在
失败的那一条正是签名合法、无 Todo 的情形:
结论:这条红项的正解是"改测试",不是"改产品"。#7523 已经把它改完了,方向上属于 建议本 PR 关闭,不要合并;否则会把主干刚定下的 English verdict: this PR is obsolete on current main and contradicts the contract #7523 just |
Summary
missing_turn_lineagecontract error when a normal host route has neither a selected Todo nor a signed scoped request identityContext
Commit
3ebad9d021added scoped settlement identity resolution for ordinary requests. It also changed aREADY_FOR_HOSTenvelope with no selected Todo and no scoped identity intoBLOCKEDbefore_session_plancould return its existing missing-lineage contract error.The regression reproduced on
main@544aa0fee5dad33e3b70496dadfb3ffd36400e13and failed the existingtest_turn_plan_missing_todo_does_not_bypass_contract_errorsassertion in both the Ark adapter job and MemT adapter job observed from #7603. This branch is now rebased onmain@652f503842609e948e8ff832ae3977f23f79f28d.This PR is intentionally separate from #7603's private-I/O runtime change. The unrelated browser-smoke baseline failures have focused owners in #7599 (delegation-search, merged) and #7620 (team-evidence, open with its hosted target and Release build passing).
Validation
pytestmissing-Todo contract regression: 2 passedtests/test_loopx_turn_driver.py: 147 passed; 1 local Windows fixture-setup failure before this route logic (_fake_codexreturned a packaged executable that the test attempted to read as UTF-8)ruff check loopx/control_plane/turn_driver/driver.py: passedmypy --platform linux: 17 files passedThis PR's hosted Release Artifacts build failed at
team-evidence-return-smoke.mjs:133, the same baseline fixture-state leak observed on #7603. #7620 fixes that independent failure; its hostedchat-bundle-browser (2)and Release build both pass. #7618 still requires ordinary review and a fresh post-dependency run before merge consideration. No merge is requested by this submission.