Skip to content

test(workspace): restore cross-window original-media coverage - #7725

Merged
loopx-agent merged 1 commit into
mainfrom
codex/release220-takeover-20261030
Oct 30, 2026
Merged

loopx-agent merged 1 commit into
mainfrom
codex/release220-takeover-20261030

Conversation

@loopx-agent

Copy link
Copy Markdown
Collaborator

Problem and result

After #7663, one transport response contains up to 48 delegation records. The media regression still seeded only 13 records and held offset 12, so it could no longer exercise its promised later-window refresh or snapshot-drift boundary.

Reuse the existing SQLite/Inbox/HTTP fixture with 61 synthetic requests. Load all display pages, hold the second transport window at offset 48, and retain the earliest open original plus the final request’s native return through refresh. Exact-purpose row selection distinguishes the original request from repeated fixture titles. Existing media, source, cancellation, recovery and zero-write assertions remain in place.

This fixes the release regression’s coverage. It changes no product UI, backend, transport size, authority, timeout or model behavior. The original-history verification proposal in #7692 remains a separate product change.

Validation

Tested commit: 51702131ff72c26d5d4e72f4b04c55ce9d93ef08.

  • Canonical packaged Chat release build passed.
  • node apps/presentation/dashboard/smoke/delegation-media-browser-smoke.mjs passed against real disposable SQLite/Inbox/HTTP: 61 records, atomic two-window refresh, native return in the open reader, original full body/images/quotes, source errors and recovery, cancellation/query changes, bilingual desktop and 390px layouts, focus/scroll retention, zero browser writes and fixture cleanup.
  • JavaScript syntax, diff hygiene and the changed synthetic fixture’s public-boundary scan passed.
  • Exact-scope change-quality receipt is valid. Standard premerge passed all 4 direct and 2 selected checks, with no skips or holds.
  • Two initial launches failed during isolated browser dependency discovery. Explicit repository Playwright and headless-browser locations restored the existing test environment; no assertion, deadline or product setting was weakened. Those attempts remain failed setup evidence.

Full release qualification is running separately and is not implied by this focused test result. No live model, installed-user migration or public release occurred in this PR.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
(cherry picked from commit 3c6eaf39c3b74fe34b7ffef172cec6e1e538164d)

@loopx-agent loopx-agent left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer: model_agent; gpt-6.1-sol; OpenAI; runtime_reported; reasoning_effort=max

Approval conclusion (author-owned PR; GitHub blocks formal self-approval)

未发现阻塞性问题;本次结论只覆盖 51702131ff72c26d5d4e72f4b04c55ce9d93ef08 的既有媒体回归修复。

动机 / Motivation

发布维护者需要验证委派刷新后仍能阅读原文、图片和接收者回传。

旧用例只有13条记录,单次48条响应已覆盖全部记录,无法触发等待中的后续窗口;新用例用61条记录实际经过48加13两次响应。

打包界面实际完成跨窗口刷新和失败恢复,同时保留完整原文、图片、原生回传及零浏览器写入。

不改变产品显示、权限、传输大小或模型行为,也不把本用例通过当作整版发布合格。

改动思路 / Approach

修改既有集成用例即可恢复跨页压力;新增运行器、状态或产品分支均无必要。 当前 PR 只修复既有媒体回归的样本规模、跨页拦截位置和精确行选择。

这里的“页”有两层:界面每次显示12条,HTTP一次最多取48条。旧13条fixture并没有第二个HTTP窗口;只检查界面“更多记录”会误以为已覆盖多窗口。新用例仍沿同一SQLite/Inbox/HTTP owner读取61条,在实际offset48处挂起/篡改后续响应。浏览器原图和长文是合成enrichment,native回传来自真实Inbox drain,二者没有混称。这个小边界直接修复已有公开手动入口,不引入新的provider、状态或后台工作。

具体改动 / Changes

依据 docs/development/good-smokes.md,固定版本 e8f4c6f8125e3cc0ef912afac653d5542671392f。Prefer Semantic Pressure:保留源错误、迟到读取、快照漂移和取消负例,并让fixture真正跨越传输窗口。Consolidate Without Losing Coverage:改原用例和原fixture参数,未复制新的集成测试。公开调用入口仍见 docs/development/frontend-delivery.md。

关键代码讲解

  • apps/presentation/dashboard/smoke/delegation-media-browser-smoke.mjs:16 的fixture spawn显式传61条。独立HTTP观察确认旧13条只返回13、无next_offset;61条返回48加13、同一digest、61个唯一请求。基准产品文件与head逐一相同;该对比说明测试压力差异,没有声称另跑一个旧版产品checkout。
  • apps/presentation/dashboard/smoke/delegation-media-browser-smoke.mjs:95 的 originalRow 精确匹配未加“记录”后缀的原目的。61条fixture会重复目的,旧宽泛匹配可能匹配多行;当前中英文入口复用同一选择方法,不改变产品搜索。
  • apps/presentation/dashboard/smoke/delegation-media-browser-smoke.mjs:198 的offset48拦截作用于真实后续响应。hold期间保留61条旧视图,释放后再整体更新;drift分支拒绝混合快照。原生回传、焦点、scroll、关闭和查询切换的断言保持并执行。

对主干的风险 / Risks

全diff为一个测试文件,22行新增、14行删除;没有生产默认、协议、权限或兼容格式变化。更大fixture增加准备成本,但13条在当前48条窗口下无法施加相同压力,新增一套运行器也更昂贵。已检查相邻搜索smoke及#7692:列表搜索和完整历史验证仍有各自边界,本次不复制其产品修复。

PASS:canonical Chat构建、61条真实SQLite/HTTP打包媒体路径、双语桌面与390px、源失败恢复、晚到取消、原生回传、零浏览器写入、语法、公开边界,以及4项direct和2项selected premerge。严格质量回执有效,无跳过或manual hold。两次初始启动因隔离环境未暴露既有浏览器依赖而失败;显式指定已有依赖后完整运行通过,没有改断言或deadline。按当前政策未查询CI。剩余风险是合成enrichment不能证明真实外部Lark线程和所有附件格式;整版发布资格另验。

我的整体评价 / Verdict

本PR完成其测试维护目标;long_horizon不适用,用户交互保持,未据测试结果声称长程收益。所有渲染实现和样式逐字不变,因此无新视觉设计需验收;未验证安装态App或真实外部会话。修改既有集成用例即可恢复跨页压力;新增运行器、状态或产品分支均无必要。 当前 PR 只修复既有媒体回归的样本规模、跨页拦截位置和精确行选择。 没有新增共享语义词表,局部fixture变化已有明确披露。远端head已核对,发布批准结论后仍须独立readiness与授权合并。

English verdict: APPROVE 51702131ff72c26d5d4e72f4b04c55ce9d93ef08 — restores real cross-window media coverage with the existing fixture; focused packaged validation and required local checks passed. This is not full release qualification.

@loopx-agent
loopx-agent merged commit 225698b into main Oct 30, 2026
11 checks passed
@loopx-agent
loopx-agent deleted the codex/release220-takeover-20261030 branch October 30, 2026 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant