Repository navigation
feat(ts): ts.check names the type checker TsgoCheck runs - #376
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ts.check(binary, args)names the program theTsgoCheckvalidation action runs instead of the tsgo toolchain's compiler. Without it nothing changes.args, then the command line tsgo gets (--project <cfg> --noEmit --explainFiles --pretty false, plus--checkers N), and has to print and exit as tsgo does: the action still parses its--explainFileslisting for the strict-deps check.oj typecheck(oj 0.4.0+) does that.TsgoCheckchanges. Declaration emit (TsgoDeclare), the editor project and Gazelle stay on tsgo, so the tsgo toolchain is still required.--@rules_typescript//ts:check=@rules_typescript//ts:tsgo_checkruns one build on tsgo whatever the module names, for comparing the two.ts.lint: acheck_configrepo from the extension, a//ts:checklabel flag, and aCheckConfigInfoprovider onts_compile's_checkattribute.Docs:
docs/guides/check.md. Changelog:changelog.d/check-binary.md.Tests (
tests/check): with a fake checker,TsgoCheck's argv after--is the checker, its args, then--project, with--noEmitand--explainFiles, and the checker is an action input;TsgoDeclareand the IDE project keep tsgo; thetsgo_checkconfig puts tsgo back.bazel test //tests/check/... //tests/checkers/... //tests/lint/...passes.