Repository navigation
test(integration): consumer_crates reads the Rust versions from MODULE.bazel - #385
Merged
Merged
Conversation
…azel The isolation check named the tools' toolchain as 1.99.1 and the consumer's as 1.91.0, so every Rust bump in MODULE.bazel had to edit the test too. It now reads each rust.toolchain version from the module that pins it, and fails if the two match, since then the check could not tell them apart. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mikn
force-pushed
the
mikn/consumer-crates-rust-version
branch
from
November 4, 2026 10:13
d3ecfda to
c9f94c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 2026-10-31 the Rust toolchain moved from 1.98.0 to 1.99.1 inside the oj 0.3.1 bump (#377), and
consumer_crates_testhad to be edited by hand too: it named both Rust versions as string literals, so every Rust bump inMODULE.bazelbroke the test until someone updated it.Observed in production: no; found while bumping Rust in #377. Gain: a Rust bump no longer has to edit the test.
MODULE.bazeland the consumer's from its fixtureMODULE.bazel, each from therust.toolchain(version = ...)call that pins it, and fails if the two are equal.rust.toolchainpins, so the check that native tools and a consumer's Rust code use separate compilers keeps working after a bump with no test edit.1.99.1and1.91.0from the two modules, so the expected toolchain directories (_1_99_1_rust_toolchain/,_1_91_0_rust_toolchain/) are the same strings as before; the rootMODULE.bazelwas already in the test'sdata.🤖 Generated with Claude Code