Skip to content

test(integration): consumer_crates reads the Rust versions from MODULE.bazel - #385

Merged
mikn merged 1 commit into
mainfrom
mikn/consumer-crates-rust-version
Nov 5, 2026
Merged

mikn merged 1 commit into
mainfrom
mikn/consumer-crates-rust-version

Conversation

@mikn

@mikn mikn commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

On 2026-10-31 the Rust toolchain moved from 1.98.0 to 1.99.1 inside the oj 0.3.1 bump (#377), and consumer_crates_test had to be edited by hand too: it named both Rust versions as string literals, so every Rust bump in MODULE.bazel broke the test until someone updated it.

Observed in production: no; found while bumping Rust in #377. Gain: a Rust bump no longer has to edit the test.

  • What: the test reads the tools' Rust version from rules_typescript's MODULE.bazel and the consumer's from its fixture MODULE.bazel, each from the rust.toolchain(version = ...) call that pins it, and fails if the two are equal.
  • Goal: the test takes both Rust versions from the rust.toolchain pins, so the check that native tools and a consumer's Rust code use separate compilers keeps working after a bump with no test edit.
  • Evidence: the pattern yields 1.99.1 and 1.91.0 from the two modules, so the expected toolchain directories (_1_99_1_rust_toolchain/, _1_91_0_rust_toolchain/) are the same strings as before; the root MODULE.bazel was already in the test's data.
  • Risk/rollback: test only. If someone later sets the fixture's pin to the tools' version, the test now fails, because it could no longer tell the two compilers apart. Revert the commit.
  • Merges next: nothing depends on it.

🤖 Generated with Claude Code

…azel

The isolation check named the tools' toolchain as 1.99.1 and the consumer's
as 1.91.0, so every Rust bump in MODULE.bazel had to edit the test too. It now
reads each rust.toolchain version from the module that pins it, and fails if
the two match, since then the check could not tell them apart.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mikn
mikn force-pushed the mikn/consumer-crates-rust-version branch from d3ecfda to c9f94c1 Compare November 4, 2026 10:13
@mikn
mikn merged commit d04b2b9 into main Nov 5, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant