decoder: Ensure safe handling of illegal instructions by blocking all side effects#2384
Closed
Anubhav-30 wants to merge 1 commit intolowRISC:masterfrom
Closed
decoder: Ensure safe handling of illegal instructions by blocking all side effects#2384Anubhav-30 wants to merge 1 commit intolowRISC:masterfrom
Anubhav-30 wants to merge 1 commit intolowRISC:masterfrom
Conversation
Contributor
|
This PR gates signals that do not actually produce any architectural side effects. We are closing this PR as the proposed changes do not align with our current development priorities, address any tracked issues, or meet our required technical standards. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change strengthens the handling of illegal instructions in the decoder
by ensuring that no unintended side effects are triggered when an illegal
instruction is detected.
In addition to disabling write and control signals, this update explicitly:
This prevents any unintended data access, control flow changes, or CSR
side effects from occurring due to partially decoded illegal instructions.
The change is non-intrusive and aligns with safe CPU design practices,
ensuring that illegal instructions are fully contained within the decoder
stage without affecting downstream pipeline behavior.