[proj] KMAC D1 sign-off - #704
Open
tchilikov-semify wants to merge 1 commit into
Open
Conversation
tchilikov-semify
force-pushed
the
d1_signoff_kmac
branch
from
September 7, 2026 14:55
4b77cb1 to
8831052
Compare
tchilikov-semify
marked this pull request as ready for review
September 7, 2026 14:56
tchilikov-semify
force-pushed
the
d1_signoff_kmac
branch
from
September 7, 2026 15:01
8831052 to
fb0af89
Compare
Collaborator
Author
|
Closes #489 |
marnovandermaas
left a comment
Collaborator
There was a problem hiding this comment.
Some initial comments, but after that happy to approve after that.
Add the D1 design sign-off checklist for the KMAC and move it to D1 in the stage table.
tchilikov-semify
force-pushed
the
d1_signoff_kmac
branch
from
September 8, 2026 08:56
fb0af89 to
3ccd577
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the D1 design sign-off checklist for the KMAC and move it to D1 in the stage table.