Skip to content

fix: bound android kit upper version in expo config plugin #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesnrokt merged 1 commit into from
May 28, 2026
Merged

fix: bound android kit upper version in expo config plugin #332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions plugin/src/withMParticleAndroid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,9 +364,12 @@ const withMParticleAppBuildGradle: ConfigPlugin<MParticlePluginProps> = (
}

// Generate kit dependency lines
// Use + for version to auto-match core SDK version
// Bounded range matches the core SDK range in android/build.gradle so the
// kit and core stay paired on a 5.x line. An unbounded `+` would resolve
// to a pre-release (e.g. 6.0.0-rc.1) and transitively drag the core past
// the bridge's compiled-against API surface.
const kitDependencies = props.androidKits
.map(kit => ` implementation "com.mparticle:${kit}:+"`)
.map(kit => ` implementation "com.mparticle:${kit}:[5.79.0, 6.0)"`)
.join('\n');
Comment thread
jamesnrokt marked this conversation as resolved.

// Use mergeContents for idempotent injection
Expand Down
Loading