Repository navigation
chore(deps): refresh the lockfiles to close 55 security alerts - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enabling Dependabot alerts surfaced 64 open alerts (4 critical, 45 high,
15 medium) across 18 packages. 55 of them close with lockfile changes alone: the
patched versions already satisfy the ranges their dependents ask for, so this
re-resolves them in place and touches no
package.json.None of this reaches people who install the package. The published package
declares no
dependencies, and every affected package is tooling reachedthrough
expo,metro,jestorbabel. They are visible in the repo'sSecurity tab, which is why they are worth closing.
Why Dependabot's version PRs did not do this: it proposes bumps for the
dependencies we declare, and these are transitive.
yarn upgrade <pkg>does notmove transitive ones in yarn 1 either (it exits without changing anything), so
the entries were dropped from each lockfile and re-resolved with
yarn install.Closed here
handlebars(critical)shell-quote(critical)@xmldom/xmldom×23brace-expansion×8fast-uri×7js-yaml×4browserslist,compression,nanoid,postcss,source-map-js,baseline-browser-mappingStill open: 9 alerts, 6 packages
None can be closed here without forcing a major version or because no patched
release exists yet. All are pulled by build or test tooling:
node-forge×2expo→@expo/clibracesmetro-file-map→micromatchsprintf-jsbabel-plugin-istanbul→argparseuuid×2expo→@expo/config-plugins→xcodexcodeasks for^7; a major jump through a resolutionimage-size×2metrometroasks for^1; a major jumpdecode-uri-componentexpo-router→query-stringquery-stringasks for^0.2; a major jumpType of change
fix— bug fix (no public API change)feat— new backward-compatible APIdocs/chore/ci/test— no runtime changeHow was this tested?
yarn lint,yarn typecheckandyarn test(156) pass, and the exampletype-checks, both against the new lockfiles installed with
--frozen-lockfile.The example's Android and iOS builds in this PR's CI are the real check: several
of the bumps (
browserslist4.28 → 4.29,postcss,baseline-browser-mapping)sit in the example's bundling path.
Checklist
yarn lint,yarn typecheck, andyarn testall pass.CHANGELOG.mdupdated under## [Unreleased]— not applicable: nothingships to consumers from this PR.