Skip to content

refactor: migrate web Loader to @makeplane/propel Skeleton - #9766

Draft
codingwolf-at wants to merge 4 commits into
previewfrom
refactor/makeplane-skeleton-loader
Draft

refactor: migrate web Loader to @makeplane/propel Skeleton#9766
codingwolf-at wants to merge 4 commits into
previewfrom
refactor/makeplane-skeleton-loader

Conversation

@codingwolf-at

@codingwolf-at codingwolf-at commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Description

Replace @plane/ui Loader / Loader.Item in apps/web with @makeplane/propel Skeleton + SkeletonItem.

Pulse placeholders now use the design-system primitive (required aria-label, blockSize / inlineSize instead of height / width). Layout classes stay on wrappers — Propel Skeleton does not take className. Scope is web only; @plane/ui Loader is unchanged for space/editor.

Depends on unpublished Skeleton in @makeplane/propel (see Propel PR). apps/web is linked to a local tarball until that ships.

Type of Change

  • Code refactoring

Screenshots and Media (if applicable)

Loader Preview
Stretch Screenshot 2026-09-04 at 11 37 31 PM
Layout Screenshot 2026-09-04 at 11 38 00 PM
Circle Screenshot 2026-09-04 at 11 38 30 PM
Fill slot Screenshot 2026-09-04 at 11 38 51 PM

Test Scenarios

  • Open a work item and peek overview while data is loading — bones pulse, no empty flash, screen reader names the region.
  • Project work-item filters (assignee, labels, state, cycle, module) — dropdown loading rows match previous spacing.
  • Pages list / page editor / page version — toolbar and body skeletons still fill the layout.
  • Home widgets, inbox sidebar pagination, stickies grid, cycle/module analytics sidebars — loaders still occupy the same boxes.
  • Toggle light and dark; skeleton fill should follow bg-layer-1.
  • After Propel publish, swap the local tarball for the catalog version and reinstall.

References

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown

React Doctor found 12 new issues in 11 files · 12 warnings · score 80 / 100 (Needs work) · 12 fixed · vs preview

12 warnings

app/(all)/[workspaceSlug]/(projects)/browse/[workItem]/page.tsx

  • ⚠️ L35 React function has high control-flow complexity no-high-complexity-react-function
  • ⚠️ L112 Duplicated JSX structure duplicate-jsx-subtree

core/components/base-layouts/gantt/sidebar.tsx

  • ⚠️ L149 Duplicated JSX structure duplicate-jsx-subtree

core/components/common/filters/created-by.tsx

  • ⚠️ L62 Duplicated JSX structure duplicate-jsx-subtree

core/components/core/description-versions/modal.tsx

  • ⚠️ L144 Duplicated JSX structure duplicate-jsx-subtree

core/components/core/image-picker-popover.tsx

  • ⚠️ L56 React function has high control-flow complexity no-high-complexity-react-function

core/components/core/modals/bulk-delete-issues-modal.tsx

  • ⚠️ L189 Duplicated JSX structure duplicate-jsx-subtree

core/components/cycles/active-cycle/cycle-stats.tsx

  • ⚠️ L55 React function has high control-flow complexity no-high-complexity-react-function

core/components/cycles/active-cycle/productivity.tsx

  • ⚠️ L31 React function has high control-flow complexity no-high-complexity-react-function

core/components/cycles/active-cycle/progress.tsx

  • ⚠️ L29 React function has high control-flow complexity no-high-complexity-react-function

core/components/integration/single-integration-card.tsx

  • ⚠️ L53 React function has high control-flow complexity no-high-complexity-react-function

core/components/pages/loaders/page-content-loader.tsx

  • ⚠️ L52 Duplicated JSX structure duplicate-jsx-subtree

Reviewed by React Doctor for commit 5d9c8c7. See inline comments for fixes.

@codingwolf-at
codingwolf-at force-pushed the refactor/makeplane-skeleton-loader branch from be9adeb to da1a7ab Compare September 4, 2026 17:31
@codingwolf-at codingwolf-at self-assigned this Sep 4, 2026
Updated various components across the application to use Skeleton and SkeletonItem from @makeplane/propel/components/skeleton instead of Loader for displaying loading states. This change enhances the user experience by providing a more visually appealing loading indication. Components affected include issue details pages, analytics loaders, and various modals.
@codingwolf-at codingwolf-at reopened this Sep 4, 2026
@codingwolf-at codingwolf-at changed the title Refactor/makeplane skeleton loader refactor: migrate web Loader to @makeplane/propel Skeleton Sep 4, 2026
Updated various components to improve loading state visuals by integrating Skeleton and SkeletonItem from @makeplane/propel/components/skeleton. This change affects issue details pages, analytics loaders, and other UI elements, providing a more cohesive and visually appealing user experience during loading times.
Added translations for loading states in various languages, including Czech, German, English, Spanish, French, Indonesian, Italian, Japanese, Georgian, Korean, Polish, Brazilian Portuguese, Romanian, Russian, and Slovak. This enhancement improves the user experience by providing localized loading messages across the application.
Replaced static aria-labels in various components with localized strings using the translation function. This change enhances accessibility and user experience by providing contextually relevant loading messages across the application. Components affected include issue details, analytics loaders, and various modals.
Comment thread apps/web/core/components/base-layouts/gantt/sidebar.tsx
Comment thread apps/web/core/components/core/description-versions/modal.tsx
Comment thread apps/web/core/components/core/image-picker-popover.tsx
Comment thread apps/web/core/components/core/modals/bulk-delete-issues-modal.tsx
Comment thread apps/web/core/components/integration/single-integration-card.tsx
Comment thread apps/web/core/components/pages/loaders/page-content-loader.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant