Skip to content

cli: remove standalone doublezero-geolocation binary#3727

Merged
ben-dz merged 1 commit into
mainfrom
bdz/remove-standalone-geolocation-cli
May 28, 2026
Merged

cli: remove standalone doublezero-geolocation binary#3727
ben-dz merged 1 commit into
mainfrom
bdz/remove-standalone-geolocation-cli

Conversation

@ben-dz
Copy link
Copy Markdown
Contributor

@ben-dz ben-dz commented May 19, 2026

Summary of Changes

  • Delete the `client/doublezero-geolocation-cli` crate (the standalone `doublezero-geolocation` binary)
  • Delete the three GoReleaser configs (`release/.goreleaser.{base,devnet,testnet}.geolocation-cli.yaml`) and the dedicated release workflow (`.github/workflows/release.geolocation-cli.yml`)
  • Remove `doublezero-geolocation-cli` from the Cargo workspace `members` list and strip the `geolocation-cli` matrix entry from the devnet daily and testnet tag-push release workflows

The `smartcontract/programs/doublezero-geolocation` onchain program and its workspace dependency are untouched — only the standalone CLI binary goes away.

Diff Breakdown

Category Files Lines (+/-) Net
Scaffolding 7 +0 / -261 -261
Config/build 7 +0 / -153 -153
Generated 1 +0 / -15 -15
Docs 1 +1 / -0 +1
Total 16 +1 / -429 -428

Pure deletion — no new logic.

Key files (click to expand)
  • `client/doublezero-geolocation-cli/src/main.rs` — entry point and subcommand dispatch (−132)
  • `release/.goreleaser.base.geolocation-cli.yaml` — base GoReleaser config (−85)
  • `.github/workflows/release.geolocation-cli.yml` — dedicated release workflow (−39)
  • `client/doublezero-geolocation-cli/src/cli/user.rs` — user subcommand wrappers, superseded by `doublezero geolocation user` (−36)
  • `client/doublezero-geolocation-cli/src/cli/probe.rs` — probe subcommand wrappers, superseded by `doublezero geolocation probe` (−30)
  • `client/doublezero-geolocation-cli/Cargo.toml` — crate manifest (−26)
  • `Cargo.lock` — dependency graph regen (−15)
  • `Cargo.toml` — workspace member removal (−1)

Testing Verification

  • `cargo check --workspace` passes cleanly after removing the crate
  • `cargo test -p doublezero_cli` passes (328 tests) — confirms geolocation commands remain functional via `doublezero geolocation ...`
  • `make rust-fmt && make rust-lint` pass with no warnings

@ben-dz ben-dz force-pushed the bdz/remove-standalone-geolocation-cli branch from 2add559 to ce038ba Compare May 19, 2026 18:13
@nikw9944 nikw9944 force-pushed the bdz/remove-standalone-geolocation-cli branch from ce038ba to 2cf0fac Compare May 28, 2026 14:56
@ben-dz ben-dz marked this pull request as ready for review May 28, 2026 15:02
@ben-dz ben-dz enabled auto-merge (squash) May 28, 2026 15:03
@ben-dz ben-dz merged commit e869575 into main May 28, 2026
33 checks passed
@ben-dz ben-dz deleted the bdz/remove-standalone-geolocation-cli branch May 28, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants