fix(ios): apply fadeWhenFacingNorth independently of enabled#1125
Open
charles-plante wants to merge 1 commit into
Open
fix(ios): apply fadeWhenFacingNorth independently of enabled#1125charles-plante wants to merge 1 commit into
charles-plante wants to merge 1 commit into
Conversation
On iOS, CompassSettings.fadeWhenFacingNorth was ignored unless enabled
was also set. CompassController.updateSettings only assigned
compass.visibility inside `if let visible = settings.enabled { ... }`,
so a call that set only fadeWhenFacingNorth never reached the native
API and the compass stayed .adaptive, fading out at north. Android
applies each field independently, so the platforms behaved differently.
Apply enabled and fadeWhenFacingNorth independently, reading the current
visibility for whichever field the caller didn't provide, mirroring the
Android CompassMappings implementation.
Related to mapbox#602.
|
Charles Plante seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Author
The license is signed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iOS, CompassSettings.fadeWhenFacingNorth was ignored unless enabled was also set. CompassController.updateSettings only assigned compass.visibility inside
if let visible = settings.enabled { ... }, so a call that set only fadeWhenFacingNorth never reached the native API and the compass stayed .adaptive, fading out at north. Android applies each field independently, so the platforms behaved differently.Apply enabled and fadeWhenFacingNorth independently, reading the current visibility for whichever field the caller didn't provide, mirroring the Android CompassMappings implementation.
Related to #602.