Repository navigation
Sync fmsgid DD with quota pools, and show why API key creation fails - #23
Merged
Merged
Conversation
fmsgid main (quota pools, markmnl/fmsgid#7) selects address.quota_pool, which the copied fmsgid DD here didn't have, so every address lookup failed with 500 ("column a.quota_pool does not exist"). The integration tests then stopped at creating API keys: create-delegation failed checking the owner in fmsgid, and only the rotate fallback's error ("grant not found") was printed. Refresh docker/postgres/init/002-fmsgid-dd.sql with scripts/update-dd.sh from fmsgid main. When both create-delegation and rotate-delegation fail, print both errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Integration tests have been failing at "Creating integration-test API keys..." with
Failed to create API key for @alice@hairpin.local/api-key: grant not found. They fail with main refs too (run 38033521036), not just with feature branches.Root cause. fmsgid main now selects
address.quota_pool(quota pools, markmnl/fmsgid#7). The fmsgid DD copied into this repo (docker/postgres/init/002-fmsgid-dd.sql) predates that column. So everyGET /fmsgid/:addressfailed with 500:ERROR: column a.quota_pool does not exist.How that became the error above:
fmsg-webapi api-key create-delegationfailed checking the owner:api-key: checking owner in fmsgid: unexpected status 500.rotate-delegation, which fails withgrant not foundbecause no grant exists yet.What
002-fmsgid-dd.sqlfrom fmsgid main withscripts/update-dd.sh(--checknow reports everything up to date).test/run-tests.shprints both the create-delegation and rotate-delegation errors when both fail, so a failure like this names its real cause.Tests
🤖 Generated with Claude Code