fix(docs): resolve localized anchors in MCP lookups - #17
Merged
Merged
Conversation
matcra587
added this pull request to stack #18
September 21, 2026 23:55
matcra587
marked this pull request as ready for review
September 22, 2026 00:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Page fragments were discarded and search breadcrumbs could suggest unusable heading lookups. Select the requested section with precedence
heading,query, fragment, then full page. Resolve translated published IDs through bounded upstream HTML when needed, retain the resolved selection in continuations and return an actionable error for missing or ambiguous targets.Search results with fragments now include executable follow-up calls. Hits absent from the catalogue retain their rank and carry an availability warning. README adds a compact, dated live-results summary and links to CONTRIBUTING for test instructions.
Review Focus
anchor_resolution.go: published heading IDs must map unambiguously to Markdown; HTML is never cached as a page body.pagination.go: selection precedence, snapshot validation and continuation state.apisearch.goand MCP tests: executable fragment calls, unavailable-hit notices and independent upstream body comparisons.Test Procedure
mise run ci: formatting, lint, offline race tests, vulnerability checks, release checks and all five compilation targets.CGO_ENABLED=1 GOFLAGS=-race mise run test:integration: actual stdio MCP exchanges with the checkout's binary.Pre-flight Checklist
Additional Notes
Published-anchor verification may require one additional HTML fetch, capped at 8 MiB with the existing timeout and redirect guards. Ambiguous targets fail explicitly. Uncatalogued search hits remain unavailable until the catalogue refreshes. Live samples do not validate every translated article.