Skip to content

fix(radio): dispatch input event on keyboard navigation#5983

Open
ErnestHysa wants to merge 1 commit into
material-components:mainfrom
ErnestHysa:ernest-main
Open

fix(radio): dispatch input event on keyboard navigation#5983
ErnestHysa wants to merge 1 commit into
material-components:mainfrom
ErnestHysa:ernest-main

Conversation

@ErnestHysa

Copy link
Copy Markdown

Fixes #5949

Dispatches an InputEvent before the change event when keyboard-navigating radio buttons with arrow keys, matching native <input type='radio'> behavior where both input and change events fire on user interaction.

Changes

  • Modified SingleSelectionController.handleKeyDown in radio/internal/single-selection-controller.ts to dispatch an InputEvent before the change event
  • Added test in radio/radio_test.ts to verify input event is dispatched on keyboard navigation

Testing

Added a new test case dispatched an input event on user navigation that verifies the input event is fired when using arrow keys to navigate radio buttons.

Fixes material-components#5949

Dispatch an InputEvent before the change event when keyboard-navigating
radio buttons with arrow keys, matching native <input type='radio'> behavior
where both input and change events fire on user interaction.

Added test to verify input event is dispatched on keyboard navigation.
@google-cla

google-cla Bot commented May 31, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ErnestHysa

Copy link
Copy Markdown
Author

CLA flag noted — checking the linked Google account. The change itself is a small dispatch tweak in single-selection-controller.ts with a test in radio_test.ts; happy to address any review feedback once the CLA clears.

@asyncliz

Copy link
Copy Markdown
Collaborator

@ErnestHysa it looks like the commit was made with the @ernest account, which hasn't signed the CLA. Can you either amend the commit using your other account with a forced update, or sign the CLA for that account?

@asyncliz asyncliz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience! This LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants