fix(radio): dispatch input event on keyboard navigation#5983
Conversation
Fixes material-components#5949 Dispatch an InputEvent before the change event when keyboard-navigating radio buttons with arrow keys, matching native <input type='radio'> behavior where both input and change events fire on user interaction. Added test to verify input event is dispatched on keyboard navigation.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
CLA flag noted — checking the linked Google account. The change itself is a small dispatch tweak in single-selection-controller.ts with a test in radio_test.ts; happy to address any review feedback once the CLA clears. |
|
@ErnestHysa it looks like the commit was made with the @ernest account, which hasn't signed the CLA. Can you either amend the commit using your other account with a forced update, or sign the CLA for that account? |
asyncliz
left a comment
There was a problem hiding this comment.
Thanks for your patience! This LGTM
Fixes #5949
Dispatches an
InputEventbefore thechangeevent when keyboard-navigating radio buttons with arrow keys, matching native<input type='radio'>behavior where bothinputandchangeevents fire on user interaction.Changes
SingleSelectionController.handleKeyDowninradio/internal/single-selection-controller.tsto dispatch anInputEventbefore thechangeeventradio/radio_test.tsto verifyinputevent is dispatched on keyboard navigationTesting
Added a new test case
dispatched an input event on user navigationthat verifies theinputevent is fired when using arrow keys to navigate radio buttons.