Indonesian Stop Words (and a bug fix) - #1
Open
sdsdkkk wants to merge 3 commits into
Open
Conversation
…non-alphanumeric with spaces before splitting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for building this gem. I'm using it for my project with Indonesian documents. I added Indonesian stop words to the listed stop words, and I tried to fix a bug I found when using this gem. Please review the changes 🙏
Changes:
d.downcase!intod.downcase(without!). as the earlier returnedniland raises aNoMethodErrorwhen callinggsub(it is caught by thebegin...rescueblocks though)gsubparameters on line 138 in the filelib/ruby-tf-idf.rb(the original parameters are not suited for my usage, but I want to know what you think about it)*.swpin.gitignorefor vim users