Conversation
Signed-off-by: Karl Hammond <kaiserkarl31@yahoo.com>
Signed-off-by: Karl Hammond <kaiserkarl31@yahoo.com>
Signed-off-by: Karl Hammond <kaiserkarl31@yahoo.com>
Signed-off-by: Karl Hammond <kaiserkarl31@yahoo.com>
Signed-off-by: Karl Hammond <kaiserkarl31@yahoo.com>
Signed-off-by: Karl Hammond <kaiserkarl31@yahoo.com>
Signed-off-by: Karl Hammond <kaiserkarl31@yahoo.com>
|
Thanks for your willingness to contribute to MathJax! It looks like you have put in a lot of work on this. I have only had the chance to look it over briefly, but will give it a more detailed look as soon as I can. I did not several issues that I would want to address, but overall it looks promising. I will bring up your contribution at the next developers' meeting. One possible option would be for you to offer the extension as a third-party package rather than folding it into MathJax's core respository. That would give you complete control over your code, and this approach has been taken by several other contributions. Just a thought. |
|
@dpvc I am willing to offer the thermodynamics package either way. If it's faster/easier to offer it as a third-party extension, I'm happy to do that, but I don't know how; please advise. Basically, I wrote this in large part so I can more easily post on things like Chemistry Stack Exchange, and I hope I can use it in Canvas and similar course-content-delivery programs as well. However makes that happen fastest is what I will probably do. Thanks! |
Last I checked, Stack Exchange was still using MathJax v2, so this would not be available there even if included in the MathJax packages, and as a third-party extension, they would have to configure their copy to allow it to be loaded (for security reasons). For your own sites, you would be able to do it, but not on other people's sites. We discussed this in the developers' meeting last week, and we would be willing to take this on as one of the MathJax packages, pending its successful code review. |
This PR contains code to implement the vast majority of the commands in the LaTeX package
thermodynamics(written by the same author).This version does not implement all of the options the LaTeX package does, but most of the non-textbook-specific options are supported.
If this PR is incorporated into MathJax, I will add a section to the documentation on CTAN that denotes the limitations the MathJax version has that are different from the LaTeX package.
There are a lot of commands and environments in this package, and I was not certain how the MathJax developers do unit tests/etc., so with that in mind, I include an example HTML file that I used to test the functionality at the bottom of this message.
Some things to note:
(1) Before I started this project, I had not written anything in JavaScript since about 1998, and I had never heard of TypeScript before, so if you see something and think, "Why did he do it that way?" by all means, change it to something that makes more sense!
(2) I may have done some things in here that do not make a lot of sense (see point #1), and there are probably a few ways to break it that I haven't found yet.
(3) I was able to get this working and tested it off of the
masterbranch, but thedevelopbranch code currently posted does not seem to create a valid package that I can import in my browser. There should be no changes to any files except the five associated with the package, however.(4) Some of the package options are currently commented out; these may (or may not?) be implemented later, but they won't work now.
Example file to test this package: